From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Grandegger <wg@grandegger.com>
Date: Mon, 02 Jun 2008 12:06:10 +0200
Subject: [U-Boot-Users] [PATCH] TQM85xx: NAND support via local bus UPMB
In-Reply-To: <20080530182858.GA28822@polina.dev.rtsoft.ru>
References: <1211998349-2117-9-git-send-email-wg@grandegger.com>
	<1211998349-2117-10-git-send-email-wg@grandegger.com>
	<1211998349-2117-11-git-send-email-wg@grandegger.com>
	<1211998349-2117-12-git-send-email-wg@grandegger.com>
	<20080528182531.GA3308@loki.buserror.net>
	<483DA6AD.6030509@grandegger.com>
	<20080529113932.GA5835@polina.dev.rtsoft.ru>
	<483E9A56.3040200@grandegger.com>
	<20080529124422.GA8247@polina.dev.rtsoft.ru>
	<484040C0.1030103@grandegger.com>
	<20080530182858.GA28822@polina.dev.rtsoft.ru>
Message-ID: <4843C612.4070905@grandegger.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Anton Vorontsov wrote:
> On Fri, May 30, 2008 at 08:00:32PM +0200, Wolfgang Grandegger wrote:
> [...]
>> Fix that, but I can still not access the device properly. I'm a bit
>> puzzled because it uses a different algorithm to access the device.
>> While my and the Linux fsl_upm driver uses NAND_ALE, NAND_CLE and
>> friends to manage the access via hwcontrol callback, the fsl_upm driver
>> of U-Boot uses the cmdfunc callback doing different things. 
> 
> I wonder if your NAND chip is a large page one? Because currently
> fsl_upm_nand hardcodes OOB stuff (bad thing, but with old mtd subsystem
> I didn't find better way ;-).
> 
> As for u-boot and linux doing different things... with this patch
> u-boot and linux are identical:
> 
> http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-nand-flash.git;a=commitdiff;h=dffa9a8b31b2c21fd3a72ba1f58dd04911b95b6f
> 
> This is in U-Boot's mtd-2.6.22.1 branch though. :-/ Your approach with hwctl
> seem to be more universal (for old mtd subsystem), since it doesn't duplicate
> MTD cmdfunc, thus should work for all NAND chips...
> 
> Could you prepare a patch that replacing fsl_upm_nand.c's current logic
> with yours (that should work for your NAND chip), and I'll test it
> on MPC8360E-RDK?

Here we go. I'm going to send 4 patches that work for me on my TQM8548
module. Could you please give it a try?

Thanks,

Wolfgang.