[U-Boot-Users] [PATCH] MPC8360ERDK: adapt NAND interface for the re-written FSL NAND UPM driver

[U-Boot-Users] [PATCH] MPC8360ERDK: adapt NAND interface for the re-written FSL NAND UPM driver

[Wolfgang Grandegger]

MPC8360ERDK: adapt NAND interface for the re-written FSL NAND UPM driver

This patch is based on the following patch sent a few minutes ago:
"[PATCH] NAND FSL UPM: driver re-write using the hwcontrol callback"
It is untested, of course. Anton, could you please give it a try.

Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
---
 board/freescale/mpc8360erdk/nand.c |   29 +++++++++++++++++++++++++++--
 1 file changed, 27 insertions(+), 2 deletions(-)

Index: u-boot/board/freescale/mpc8360erdk/nand.c
===================================================================
--- u-boot.orig/board/freescale/mpc8360erdk/nand.c
+++ u-boot/board/freescale/mpc8360erdk/nand.c
@@ -39,6 +39,28 @@ static const u32 upm_array[] = {
 	0xfffffc00, 0xfffffc00, 0xfffffc00, 0xfffffc01, /* Words 60 to 63 */
 };
 
+static int upm_setup_done;
+
+static void upm_setup(struct fsl_upm *upm)
+{
+	int i;
+
+	/* write upm array */
+	out_be32(upm->mxmr, MxMR_OP_WARR);
+
+	for (i = 0; i < 64; i++) {
+		out_be32(upm->mdr, upm_array[i]);
+		out_8(upm->io_addr, 0x0);
+	}
+
+	/* normal operation */
+	out_be32(upm->mxmr, MxMR_OP_NORM);
+	while (in_be32(upm->mxmr) != MxMR_OP_NORM)
+		eieio();
+
+	upm_setup_done = 1;
+}
+
 static int dev_ready(void)
 {
 	if (in_be32(&im->qepio.ioport[4].pdat) & 0x00002000) {
@@ -52,10 +74,9 @@ static int dev_ready(void)
 
 static struct fsl_upm_nand fun = {
 	.upm = {
-		.array = upm_array,
 		.io_addr = (void *)CFG_NAND_BASE,
 	},
-	.width = 1,
+	.width = 8,
 	.upm_cmd_offset = 8,
 	.upm_addr_offset = 16,
 	.dev_ready = dev_ready,
@@ -68,5 +89,9 @@ int board_nand_init(struct nand_chip *na
 	fun.upm.mxmr = &im->lbus.mamr;
 	fun.upm.mdr = &im->lbus.mdr;
 	fun.upm.mar = &im->lbus.mar;
+
+	if (!upm_setup_done)
+		upm_setup(&fun.upm);
+
 	return fsl_upm_nand_init(nand, &fun);
 }

[U-Boot-Users] [PATCH] MPC8360ERDK: adapt NAND interface for the re-written FSL NAND UPM driver

[Anton Vorontsov]

On Mon, Jun 02, 2008 at 12:14:51PM +0200, Wolfgang Grandegger wrote:
> MPC8360ERDK: adapt NAND interface for the re-written FSL NAND UPM driver
> 
> This patch is based on the following patch sent a few minutes ago:
> "[PATCH] NAND FSL UPM: driver re-write using the hwcontrol callback"
> It is untested, of course. Anton, could you please give it a try.
> 
> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>

Acked-by: Anton Vorontsov <avorontsov@ru.mvista.com>

[...]
> @@ -68,5 +89,9 @@ int board_nand_init(struct nand_chip *na
>  	fun.upm.mxmr = &im->lbus.mamr;
>  	fun.upm.mdr = &im->lbus.mdr;
>  	fun.upm.mar = &im->lbus.mar;
> +
> +	if (!upm_setup_done)

Not sure if this is really needed for this board though, nobody will
call this function more than once...

[U-Boot-Users] [PATCH] MPC8360ERDK: adapt NAND interface for the re-written FSL NAND UPM driver

[Wolfgang Grandegger]

Anton Vorontsov wrote:
> On Mon, Jun 02, 2008 at 12:14:51PM +0200, Wolfgang Grandegger wrote:
>> MPC8360ERDK: adapt NAND interface for the re-written FSL NAND UPM driver
>>
>> This patch is based on the following patch sent a few minutes ago:
>> "[PATCH] NAND FSL UPM: driver re-write using the hwcontrol callback"
>> It is untested, of course. Anton, could you please give it a try.
>>
>> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> 
> Acked-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> 
> [...]
>> @@ -68,5 +89,9 @@ int board_nand_init(struct nand_chip *na
>>  	fun.upm.mxmr = &im->lbus.mamr;
>>  	fun.upm.mdr = &im->lbus.mdr;
>>  	fun.upm.mar = &im->lbus.mar;
>> +
>> +	if (!upm_setup_done)
> 
> Not sure if this is really needed for this board though, nobody will
> call this function more than once...

Right, also because io_addr is hard coded. I will remove it.

Wolfgang.