public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] NAND FSL UPM: driver re-write using the hwcontrol	callback
Date: Mon, 02 Jun 2008 15:02:45 +0200	[thread overview]
Message-ID: <4843EF75.8080400@grandegger.com> (raw)
In-Reply-To: <20080602114214.GA25335@polina.dev.rtsoft.ru>

Anton Vorontsov wrote:
> On Mon, Jun 02, 2008 at 12:11:11PM +0200, Wolfgang Grandegger wrote:
>> NAND FSL UPM: driver re-write using the hwcontrol callback
>>
>> This is a re-write of the NAND FSL UPM driver using the more universal
>> hwcontrol callback (instead of the cmdfunc callback). Here is a brief
>> list of furher modifications:
>>
>> - For the time being, the UPM setup writing the UPM array has been
>>   removed from the driver and must now be done by the board specific
>>   code.
>>
>> - The bus width definition in "struct fsl_upm_nand" is now in bits to
>>   comply with the corresponding Linux driver.
>>
>> - chip->dev_read is only set if fun->dev_ready != NULL, which is
>>   required for boards not connecting the R/B pin.
>>
>> - A few issue have been fixed with MxMR bit manipulation like in the
>>   corresponding Linux driver.
>>
>> Note: I think the "io_addr" field of "struct fsl_upm" could be removed
>>       as well, because the address is already determined by
>>       "nand->IO_ADDR_[RW]", but I'm not 100% sure.
>>
>> This patch has been tested on a TQM8548 modules with the NAND chip
>> Micron MT29F8G08FABWP.
>>
>> This patch is based on the following patches posted to this list a few
>> minutes ago:
>>
>>   [PATCH] PPC: add accessor macros to clear and set bits in one shot
>>   [PATCH] 83xx/85xx/86xx: add more MxMR local bus definitions
>>
>> Anton, could you please verify if it works on your MPC8360ERDK board as
>> well. A patch will follow. In principle, the NAND driver of the TQM8272
>> should work with it as well.
> 
> Works great here (tested on MPC8360E-RDK). Thanks!

Great.

>> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> 
> Acked-by: Anton Vorontsov <avorontsov@ru.mvista.com>

All 4 patches are maintained by different people. What is the fastest
way to get these patches in? Maybe Stefan could pick them up directly?

Wolfgang.

  reply	other threads:[~2008-06-02 13:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-02 10:11 [U-Boot-Users] [PATCH] NAND FSL UPM: driver re-write using the hwcontrol callback Wolfgang Grandegger
2008-06-02 11:42 ` Anton Vorontsov
2008-06-02 13:02   ` Wolfgang Grandegger [this message]
2008-06-02 15:03     ` Stefan Roese
2008-06-02 19:32       ` Wolfgang Grandegger
2008-06-04 10:31         ` Detlev Zundel
2008-06-02 22:12 ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4843EF75.8080400@grandegger.com \
    --to=wg@grandegger.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox