public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] NAND_SPL: Remove initdram() call from nand_boot()
Date: Mon, 02 Jun 2008 14:15:15 -0500	[thread overview]
Message-ID: <484446C3.1040801@freescale.com> (raw)
In-Reply-To: <1212432526-26485-1-git-send-email-sr@denx.de>

Stefan Roese wrote:
> This patch removes the SDRAM initilization call initdram() from
> nand_boot(). This is done mainly because I experienced problems with
> some boards like Kilauea (405EX), which don't have internal SRAM (OCM)
> and relocation needs to be done to SDRAM before the NAND controller
> can get accessed. When initdram() is called later on in nand_boot(),
> this can lead to problems with variables in the bss sections like
> nand_ecc_pos[].
> 
> Signed-off-by: Stefan Roese <sr@denx.de>

Acked-by: Scott Wood <scottwood@freescale.com>

Please send via the 4xx tree in order for the initdram move to be atomic.

-Scott

  parent reply	other threads:[~2008-06-02 19:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-02 18:48 [U-Boot-Users] [PATCH] NAND_SPL: Remove initdram() call from nand_boot() Stefan Roese
2008-06-02 19:08 ` Scott Wood
2008-06-02 19:17   ` Stefan Roese
2008-06-02 19:15 ` Scott Wood [this message]
2008-06-02 19:17   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=484446C3.1040801@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox