From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Wed, 04 Jun 2008 07:25:00 -0700 Subject: [U-Boot-Users] [patch 0/6] DM9000: Several fixes/cleanups for the DM9000A controller In-Reply-To: <3efb10970806040413q5598fc0eo317d4be5add169ff@mail.gmail.com> References: <20080603132620.482930912@bohmer.net> <48455D9F.2080501@gmail.com> <484574A6.7070107@denx.de> <3efb10970806031126p7bc5b96aob62141d5073f5c89@mail.gmail.com> <4846380A.9080701@denx.de> <3efb10970806040102u75887e9am72c175c45feb9b64@mail.gmail.com> <3efb10970806040159p19197ddfxc04cb617e16ad5c5@mail.gmail.com> <484670A5.1010607@denx.de> <3efb10970806040413q5598fc0eo317d4be5add169ff@mail.gmail.com> Message-ID: <4846A5BC.1040003@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Remy Bohmer wrote: > Hello Stefano, > > >> Great ! It works, I tested now with bigger files and it sounds good ! >> > > Good news! > > >> I have seen that the complete patch (all patch 0-xx) is not so big and >> smaller as the limit of the mailing list (17k < 40k). What about to send >> only the complete patch ? It is easier to read for the review. >> > > I made it seperate patches because all changes are seperate from each other. > One does not have to install the complete series. Every step should > result in a bootable and working driver. > Some other rule says: Keep patches as small as possible... > > I looked at the complete change at first, but that makes it > unreadable, and I believe, harder to review. > Many changes are trivial, only some are more intrusive... > > >> There are some issues with the coding style, too (trailing blanks, for >> example). >> > > hmm, I have configured quilt such that it normally removes those whitespaces... > I have to find out what went wrong here. > > I only encountered one whitespace issue, in patch 5 and was able to fix it. I use the --whitespace=strip option in git-am, so trailing whitespace isn't a problem. > Wolfgang, Is the merge window for these patches still open? > If so, I will clean up the patches, and distribute it again in about an hour. > > I've applied your patches to the net repo, and since you submitted them by the deadline it should go in this release.