From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 3/8] ppc4xx: Consolidate PPC4xx SDRAM/DDR/DDR2 defines, part2
Date: Wed, 04 Jun 2008 21:10:51 -0400 [thread overview]
Message-ID: <48473D1B.4090405@gmail.com> (raw)
In-Reply-To: <1212433356-27144-3-git-send-email-sr@denx.de>
Stefan Roese wrote:
> This patch now adds a new header file (asm-ppc/ppc4xx-sdram.h) for all
> ppc4xx related SDRAM/DDR/DDR2 controller defines.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
> include/asm-ppc/ppc4xx-sdram.h | 1156 ++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 1156 insertions(+), 0 deletions(-)
> create mode 100644 include/asm-ppc/ppc4xx-sdram.h
Hi Stefan,
Not a big deal, but it would probably have been better to switch this
patch [3/8] and the previous patch [2/8] - add the header and then
remove all the code the header replaces - so that it would be git-bisect
safe.
Best regards,
gb
next prev parent reply other threads:[~2008-06-05 1:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-02 19:02 [U-Boot-Users] [PATCH 1/8] ppc4xx: Consolidate 405 and 440 NAND booting code in start.S Stefan Roese
2008-06-02 19:02 ` [U-Boot-Users] [PATCH 2/8] ppc4xx: Consolidate PPC4xx SDRAM/DDR/DDR2 defines, part1 Stefan Roese
2008-06-02 19:02 ` [U-Boot-Users] [PATCH 3/8] ppc4xx: Consolidate PPC4xx SDRAM/DDR/DDR2 defines, part2 Stefan Roese
2008-06-05 1:10 ` Jerry Van Baren [this message]
2008-06-05 4:16 ` Stefan Roese
2008-06-02 19:02 ` [U-Boot-Users] [PATCH 4/8] ppc4xx: Change Kilauea to use the common DDR2 init function Stefan Roese
2008-06-02 19:02 ` [U-Boot-Users] [PATCH 5/8] ppc4xx: Fix common ECC generation code for 440GP style platforms Stefan Roese
2008-06-02 19:02 ` [U-Boot-Users] [PATCH 6/8] ppc4xx: Use new 4xx SDRAM controller enable defines in common ECC code Stefan Roese
2008-06-02 19:02 ` [U-Boot-Users] [PATCH 7/8] ppc4xx: Remove superfluous dram_init() call or replace it by initdram() Stefan Roese
2008-06-04 10:45 ` Detlev Zundel
2008-06-04 11:16 ` Stefan Roese
2008-06-02 19:02 ` [U-Boot-Users] [PATCH 8/8] ppc4xx: Remove implementations of testdram() Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48473D1B.4090405@gmail.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox