* [U-Boot-Users] [patch] DM9000 fix status check fail 0x6d error for trizeps board @ 2008-06-05 11:03 Remy Bohmer 2008-06-06 6:54 ` Ben Warren 0 siblings, 1 reply; 4+ messages in thread From: Remy Bohmer @ 2008-06-05 11:03 UTC (permalink / raw) To: u-boot An embedded and charset-unspecified text was scrubbed... Name: dm9000-fix-loading-error-status-check-fail-0x6d.patch Url: http://lists.denx.de/pipermail/u-boot/attachments/20080605/38230522/attachment.txt ^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot-Users] [patch] DM9000 fix status check fail 0x6d error for trizeps board 2008-06-05 11:03 [U-Boot-Users] [patch] DM9000 fix status check fail 0x6d error for trizeps board Remy Bohmer @ 2008-06-06 6:54 ` Ben Warren 2008-06-06 7:44 ` Stefano Babic 0 siblings, 1 reply; 4+ messages in thread From: Ben Warren @ 2008-06-06 6:54 UTC (permalink / raw) To: u-boot On Thu, Jun 5, 2008 at 4:03 AM, Remy Bohmer <linux@bohmer.net> wrote: > According to the Application Notes of the DM9000, only the 2 bits 0:1 of > the status byte need to be checked to identify a valid packet in the fifo > > But, The several different Application Notes do not all speak the same > language on these bits. They do not disagree, but only 1 Application Note > noted explicitly that only these 2 bits need to be checked. > Even the datasheets do not mention anything about these 2 bits. > > Because the old code, and the kernel check the whole byte, I left this piece > untouched. > > However, I tested all board/DM9000[A|E|EP] devices with this 2 bit check, so > it should work. > > Notice, that the 2nd iteration through this receive loop (when a 2nd packet is > in the fifo) is much shorter now, compared to the older U-boot driver code, > so that we can maybe run into a hardware condition now that was never seen > before, or maybe was seen very unfrequently. > > Additionaly added a cleanup of a stack variable. > > Signed-off-by: Remy Bohmer <linux@bohmer.net> > > Applied to net repo. Thanks! Stefano, please test from the net repo if you can on your Trizeps board. regards, Ben ^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot-Users] [patch] DM9000 fix status check fail 0x6d error for trizeps board 2008-06-06 6:54 ` Ben Warren @ 2008-06-06 7:44 ` Stefano Babic 2008-06-06 15:55 ` Ben Warren 0 siblings, 1 reply; 4+ messages in thread From: Stefano Babic @ 2008-06-06 7:44 UTC (permalink / raw) To: u-boot Ben Warren wrote: > Applied to net repo. Thanks! > > Stefano, please test from the net repo if you can on your Trizeps board. > Done, it works, thanks. Kind regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot-Users] [patch] DM9000 fix status check fail 0x6d error for trizeps board 2008-06-06 7:44 ` Stefano Babic @ 2008-06-06 15:55 ` Ben Warren 0 siblings, 0 replies; 4+ messages in thread From: Ben Warren @ 2008-06-06 15:55 UTC (permalink / raw) To: u-boot Stefano Babic wrote: > Ben Warren wrote: > > >> Applied to net repo. Thanks! >> >> Stefano, please test from the net repo if you can on your Trizeps board. >> >> > > Done, it works, thanks. > > Great! Thanks Stefano. regards, Ben ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-06-06 15:55 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-06-05 11:03 [U-Boot-Users] [patch] DM9000 fix status check fail 0x6d error for trizeps board Remy Bohmer 2008-06-06 6:54 ` Ben Warren 2008-06-06 7:44 ` Stefano Babic 2008-06-06 15:55 ` Ben Warren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox