From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerry Van Baren <gerald.vanbaren@ge.com>
Date: Mon, 09 Jun 2008 17:03:04 -0400
Subject: [U-Boot-Users] [RFC][FSL DDR 1/8] Add proper SPD definitions
 for	DDR1/2/3
In-Reply-To: <1213041322-5456-2-git-send-email-galak@kernel.crashing.org>
References: <1213041322-5456-1-git-send-email-galak@kernel.crashing.org>
	<1213041322-5456-2-git-send-email-galak@kernel.crashing.org>
Message-ID: <484D9A88.2030805@ge.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Kumar Gala wrote:
> Also added a few helper functions for DDR1 & DDR2 to print SPD info and
> verify the checksum.
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>  common/Makefile   |    1 +
>  common/ddr_spd.c  |  504 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  include/ddr_spd.h |  249 ++++++++++++++++++++++++++
>  3 files changed, 754 insertions(+), 0 deletions(-)
>  create mode 100644 common/ddr_spd.c
>  create mode 100644 include/ddr_spd.h
> 
> diff --git a/common/Makefile b/common/Makefile
> index b425795..503c3b5 100644
> --- a/common/Makefile
> +++ b/common/Makefile
> @@ -145,6 +145,7 @@ COBJS-y += cmd_mac.o
>  COBJS-$(CONFIG_CMD_MFSL) += cmd_mfsl.o
>  COBJS-$(CONFIG_MP) += cmd_mp.o
>  COBJS-$(CONFIG_CMD_SF) += cmd_sf.o
> +COBJS-$(CONFIG_DDR_SPD) += ddr_spd.o
>  
>  COBJS	:= $(COBJS-y)
>  SRCS	:= $(AOBJS:.o=.S) $(COBJS:.o=.c)
> diff --git a/common/ddr_spd.c b/common/ddr_spd.c
> new file mode 100644
> index 0000000..bfabb93
> --- /dev/null
> +++ b/common/ddr_spd.c
> @@ -0,0 +1,504 @@
> +/*
> + * Copyright 2008 Freescale Semiconductor, Inc.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * Version 2 as published by the Free Software Foundation.
> + */
> +
> +#include <common.h>
> +#include <ddr_spd.h>
> +
> +void
> +ddr1_spd_dump(const ddr1_spd_eeprom_t *spd)

[major snippage]

Hi Kumar,

There is a "do_sdram" command in common/cmd_i2c.c that I believe is 
doing the same thing, but probably a lot less (I suspect the command is 
showing its age).

#if defined(CONFIG_CMD_SDRAM)
U_BOOT_CMD(
         isdram, 2,      1,      do_sdram,
         "isdram  - print SDRAM configuration information\n",
         "chip\n    - print SDRAM configuration information\n"
         "      (valid chip values 50..57)\n"
);
#endif

Are you aware of that command?  Is your SPD dump going to supersede it?

Best regards,
gvb