From: Shinya Kuribayashi <shinya.kuribayashi@necel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] mips: Bring over optimized memset() routine from Linux.
Date: Fri, 13 Jun 2008 16:04:52 +0900 [thread overview]
Message-ID: <48521C14.4010504@necel.com> (raw)
In-Reply-To: <484E5C9D.8000209@necel.com>
Shinya Kuribayashi wrote:
>> + andi a1, 0xff /* spread fillword */
>> + LONG_SLL t1, a1, 8
>> + or a1, t1
>> + LONG_SLL t1, a1, 16
>> +#if LONGSIZE == 8
>> + or a1, t1
>> + LONG_SLL t1, a1, 32
>> +#endif
>> + or a1, t1
>> +1:
>> +
>> +FEXPORT(__bzero)
>> + sltiu t0, a2, LONGSIZE /* very small region? */
>> + bnez t0, .Lsmall_memset
>> + andi t0, a0, LONGMASK /* aligned? */
>
> ^
>
> [further part snipped]
>
> Please fix wrong indentations with proper tabs. I know this is exactly
> the same as Linux's memset, but we prefer to fix it correctly in U-Boot.
I found that above is an intended space to indicate that the instruction
is in the delay slot. I think it's probably a good old convention in
MIPS assembly programming, and would like to leave it as it is, IMHO.
Anyway, sorry for my ignorance and please ignore my comments on this.
--
Shinya Kuribayashi
NEC Electronics
next prev parent reply other threads:[~2008-06-13 7:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 19:44 [U-Boot-Users] [PATCH] mips: Bring over optimized memset() routine from Linux Jason McMullan
2008-06-10 10:51 ` Shinya Kuribayashi
2008-06-13 7:04 ` Shinya Kuribayashi [this message]
2008-06-13 7:13 ` Wolfgang Denk
2008-07-05 22:32 ` Wolfgang Denk
2008-07-07 13:50 ` [U-Boot-Users] [PATCH] mips: Bring over optimized memset()routine " McMullan, Jason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48521C14.4010504@necel.com \
--to=shinya.kuribayashi@necel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox