[U-Boot-Users] [PATCH] Fix 4xx build issue

[U-Boot-Users] [PATCH] Fix 4xx build issue

[Anatolij Gustschin]

Building for 4xx doesn't work since commit 4dbdb768:

In file included from 4xx_pcie.c:28:
include/asm/processor.h:971: error: expected ')' before 'ver'
make[1]: *** [4xx_pcie.o] Error 1

This patch fixes the problem.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
 cpu/mpc85xx/cpu.c           |    2 +-
 include/asm-ppc/processor.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpu/mpc85xx/cpu.c b/cpu/mpc85xx/cpu.c
index 2b7e753..baf8b81 100644
--- a/cpu/mpc85xx/cpu.c
+++ b/cpu/mpc85xx/cpu.c
@@ -59,7 +59,7 @@ struct cpu_type cpu_type_list [] = {
 	CPU_TYPE_ENTRY(8572, 8572_E),
 };
 
-struct cpu_type *identify_cpu(uint ver)
+struct cpu_type *identify_cpu(u32 ver)
 {
 	int i;
 	for (i = 0; i < ARRAY_SIZE(cpu_type_list); i++)
diff --git a/include/asm-ppc/processor.h b/include/asm-ppc/processor.h
index 139e686..5b50679 100644
--- a/include/asm-ppc/processor.h
+++ b/include/asm-ppc/processor.h
@@ -968,7 +968,7 @@ struct cpu_type {
 	u32 soc_ver;
 };
 
-struct cpu_type *identify_cpu(uint ver);
+struct cpu_type *identify_cpu(u32 ver);
 
 #define CPU_TYPE_ENTRY(n, v) \
 	{ .name = #n, .soc_ver = SVR_##v, }
-- 
1.5.4.3

[U-Boot-Users] [PATCH] Fix 4xx build issue

[Stefan Roese]

On Thursday 12 June 2008, Anatolij Gustschin wrote:
> Building for 4xx doesn't work since commit 4dbdb768:
>
> In file included from 4xx_pcie.c:28:
> include/asm/processor.h:971: error: expected ')' before 'ver'
> make[1]: *** [4xx_pcie.o] Error 1
>
> This patch fixes the problem.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>

Acked-by: Stefan Roese <sr@denx.de>

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot-Users] [PATCH] Fix 4xx build issue

[Kumar Gala]

On Jun 12, 2008, at 6:51 AM, Stefan Roese wrote:

> On Thursday 12 June 2008, Anatolij Gustschin wrote:
>> Building for 4xx doesn't work since commit 4dbdb768:
>>
>> In file included from 4xx_pcie.c:28:
>> include/asm/processor.h:971: error: expected ')' before 'ver'
>> make[1]: *** [4xx_pcie.o] Error 1
>>
>> This patch fixes the problem.
>>
>> Signed-off-by: Anatolij Gustschin <agust@denx.de>
>
> Acked-by: Stefan Roese <sr@denx.de>

Acked-by: Kumar Gala <galak@kernel.crashing.org>

- k

[U-Boot-Users] [PATCH] Fix 4xx build issue

[Larry Johnson]

Stefan Roese wrote:
> On Thursday 12 June 2008, Anatolij Gustschin wrote:
>> Building for 4xx doesn't work since commit 4dbdb768:
>>
>> In file included from 4xx_pcie.c:28:
>> include/asm/processor.h:971: error: expected ')' before 'ver'
>> make[1]: *** [4xx_pcie.o] Error 1
>>
>> This patch fixes the problem.
>>
>> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> 
> Acked-by: Stefan Roese <sr@denx.de>
> 
> Thanks.
> 
> Best regards,
> Stefan

Thanks from me too, Anatolij.  I just came up with the same patch, but
decided to check the mailing list before submitting it.

Stefan, could you add this to the ppc4xx repository ASAP?

Best regards,
Larry

[U-Boot-Users] [PATCH] Fix 4xx build issue

[Stefan Roese]

On Saturday 14 June 2008, Larry Johnson wrote:
> Thanks from me too, Anatolij.  I just came up with the same patch, but
> decided to check the mailing list before submitting it.
>
> Stefan, could you add this to the ppc4xx repository ASAP?

No, I can't. This patch touches non-PPC4xx files so it shouldn't be integrated 
via the 4xx repository.

Wolfgang, could you please apply it directly soon? Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot-Users] [PATCH] Fix 4xx build issue

[Wolfgang Denk]

In message <200806150609.43832.sr@denx.de> you wrote:
>
> > Stefan, could you add this to the ppc4xx repository ASAP?
> 
> No, I can't. This patch touches non-PPC4xx files so it shouldn't be integrated 
> via the 4xx repository.
> 
> Wolfgang, could you please apply it directly soon? Thanks.

Done.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A good marriage would be between a blind wife and deaf husband.
                                               -- Michel de Montaigne

[U-Boot-Users] [PATCH] Fix 4xx build issue

[Wolfgang Denk]

In message <1213267211-9313-1-git-send-email-agust@denx.de> you wrote:
> Building for 4xx doesn't work since commit 4dbdb768:
> 
> In file included from 4xx_pcie.c:28:
> include/asm/processor.h:971: error: expected ')' before 'ver'
> make[1]: *** [4xx_pcie.o] Error 1
> 
> This patch fixes the problem.
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>

Applied, thanks!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A mouse is an elephant built by the Japanese.