From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Mon, 16 Jun 2008 08:15:56 -0400 Subject: [U-Boot-Users] [PATCH 1/1] FAT Bare Partition Support In-Reply-To: <48562B4E.6080708@seznam.cz> References: <> <1213189254-9538-1-git-send-email-antonio.costa@atmel.com> <48562B4E.6080708@seznam.cz> Message-ID: <4856597C.6070703@ge.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Michal Simek wrote: > Hi Antonio > > I am not responsible for this part of U-BOOT but your patch contain coding style > violation. > > Regards, > Michal Simek > >> Logic unit: >> Purpose: Add support for bare partitions (no partition table) >> Author: Antnoio R. Costa atmel.com> >> Date : 11 Jun 2008 >> >> Status: >> ~~~~~~ >> Some SD cards are not formatted with a partition table but with >> just a bare partition at the beginnig of the memory. >> >> I modified get_partition_info_extended to call test_block_type >> as done by print_partition_extended. In this way bare FAT partitions >> are recognised. Now we need a test for Ext2. >> >> Signed-off-by: Antonio R. Costa >> >> diff --git a/disk/part_dos.c b/disk/part_dos.c >> index 4d778ec..e5cc8aa 100644 >> --- a/disk/part_dos.c >> +++ b/disk/part_dos.c [snip] >> +static inline int le16_to_int(unsigned char *le16) >> +{ >> + return ((le16[1] << 8) + le16[0]); >> +} >> + > > this should be in header file Please use rather than making Yet Another Define. Note that the subdirectory asm gets symlinked to the appropriate arch-specific subdirectory and then the right endian munching is selected and it Just Works[tm]. PowerPC example: [snip] > Regards, > Michal Simek Thanks, gvb