public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] u-boot and CONFIG_MTD_NAND_ECC_SMC patch
Date: Tue, 17 Jun 2008 13:30:33 -0500	[thread overview]
Message-ID: <485802C9.2020802@freescale.com> (raw)
In-Reply-To: <cd7850860806101706p48653febj6f4027644b43b7f6@mail.gmail.com>

mark roths wrote:
> Sorry if this has been covered already, the problem exists in all the u-boot
> versions I have up to 1.2.0.

1.2.0 is rather old; you should check the latest code when submitting 
bug reports and patches.

> *** ../u-boot-1.1.5/drivers/nand/nand_ecc.c     2006-10-20
> 08:54:33.000000000 -0700
> --- drivers/nand/nand_ecc.c     2008-06-10 12:59:21.000000000 -0700
> ***************
> *** 118,123 ****
> --- 118,124 ----
>  {
>        u_char idx, reg1, reg2, reg3;
>        int j;
> +       u_char tmp0, tmp1;
> 
>        /* Initialize variables */
>        reg1 = reg2 = reg3 = 0;
> ***************
> *** 140,148 ****
> --- 141,157 ----
>        /* Create non-inverted ECC code from line parity */
>        nand_trans_result(reg2, reg3, ecc_code);
> 
> + #define CONFIG_MTD_NAND_ECC_SMC
>        /* Calculate final ECC code */
> + #ifdef CONFIG_MTD_NAND_ECC_SMC
> +       tmp0 = ~ecc_code[0];
> +       tmp1 = ~ecc_code[1];
> +       ecc_code[0] = tmp1;
> +       ecc_code[1] = tmp0;
> + #else
>        ecc_code[0] = ~ecc_code[0];
>        ecc_code[1] = ~ecc_code[1];
> + #endif

The current code appears to have a similar change already.

In the future, please use unified diffs, avoid whitespace mangling, and 
add a Signed-off-by: line.

-Scott

      reply	other threads:[~2008-06-17 18:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-11  0:06 [U-Boot-Users] u-boot and CONFIG_MTD_NAND_ECC_SMC patch mark roths
2008-06-17 18:30 ` Scott Wood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=485802C9.2020802@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox