From: Jens Gehrlein <sew_s@tqs.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] net: smc911x: Fix can not compile smc911x
Date: Mon, 30 Jun 2008 12:04:04 +0200 [thread overview]
Message-ID: <4868AF94.8040504@tqs.de> (raw)
In-Reply-To: <29ab51dc0806300145n5d5dbbcdq7a11e3780b71840f@mail.gmail.com>
Hi Nobuhiro,
Nobuhiro Iwamatsu schrieb:
> When enable CONFIG_DRIVER_SMC911X_16_BIT in smc911x, can not compile it.
> I revised it from "elif" preprocessor to "elif defined".
You are right. It depends on if one writes
#define NAME
or
#define NAME 1
"#elif" and "#elif defined" behave different then.
Probably, I only tested with the "number"-version.
Thank you for catching this.
Best Regards,
Jens
next prev parent reply other threads:[~2008-06-30 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 8:45 [U-Boot-Users] [PATCH] net: smc911x: Fix can not compile smc911x Nobuhiro Iwamatsu
2008-06-30 10:04 ` Jens Gehrlein [this message]
2008-06-30 17:25 ` Ben Warren
2008-07-06 22:20 ` Wolfgang Denk
2008-07-06 22:20 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4868AF94.8040504@tqs.de \
--to=sew_s@tqs.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox