public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ilya Yanok <yanok@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] mtd: CONFIG_NAND_LAZY_SCAN support (2nd rev)
Date: Mon, 30 Jun 2008 18:10:52 +0400	[thread overview]
Message-ID: <4868E96C.6000809@emcraft.com> (raw)
In-Reply-To: <4863C94A.2010602@freescale.com>

Scott Wood wrote:
>> diff --git a/common/cmd_nand.c b/common/cmd_nand.c
>> index 37eb41b..6f5d13d 100644
>> --- a/common/cmd_nand.c
>> +++ b/common/cmd_nand.c
>> @@ -236,6 +236,8 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc,
>> char *argv[])
>>      }
>>      nand = &nand_info[nand_curr_device];
>>
>> +    nand_lazy_scan_finish(nand);
>> +
>
> There are other entry points that need to be covered (e.g.
> do_nandboot, do_onenand, env_nand, jffs2, etc).  Probably better to
> put the call in nand_block_isbad().

You're right. I've added scanning in nand_block_checkbad.

> Is there any reason not to enable this unconditionally?

Don't really know. I've used config option just to provide old behavior.

--
Ilya

  reply	other threads:[~2008-06-30 14:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-26  9:50 [U-Boot-Users] [PATCH] mtd: CONFIG_NAND_LAZY_SCAN option support Ilya Yanok
2008-06-26 16:52 ` Scott Wood
2008-06-30 14:10   ` Ilya Yanok [this message]
2008-07-06 20:47     ` [U-Boot-Users] [PATCH] mtd: CONFIG_NAND_LAZY_SCAN support (2nd rev) Wolfgang Denk
     [not found] <200806301352.m5UDqk3e006278@de01egw01.freescale.net>
2008-06-30 19:50 ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4868E96C.6000809@emcraft.com \
    --to=yanok@emcraft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox