From: Jens Gehrlein <sew_s@tqs.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 2/2] Remove prototypes of nand_init() in favor of including nand.h.
Date: Tue, 01 Jul 2008 16:43:14 +0200 [thread overview]
Message-ID: <486A4282.2080102@tqs.de> (raw)
In-Reply-To: <20080522155317.GB25382@ld0162-tx32.am.freescale.net>
Hi Scott,
Scott Wood schrieb:
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> lib_arm/board.c | 10 ++--------
> lib_ppc/board.c | 4 +---
> lib_sh/board.c | 2 +-
> 3 files changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/lib_arm/board.c b/lib_arm/board.c
> index 67506b3..5e04553 100644
> --- a/lib_arm/board.c
> +++ b/lib_arm/board.c
> @@ -45,6 +45,8 @@
> #include <version.h>
> #include <net.h>
> #include <serial.h>
> +#include <nand.h>
Today, I updated my local git tree to the current U-Boot. Running my
board I saw the message "RAM Configuration:", which didn't appear before.
I think the reason is the following:
nand.h includes linux/mtd/mtd.h, which defines a macro
#define DEBUG(n, args...) do { } while(0).
This causes #ifdef DEBUG in line 198 of board.c to become true.
Could you please fix this?
Thank you very much.
Best Regards,
Jens
next prev parent reply other threads:[~2008-07-01 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 15:53 [U-Boot-Users] [PATCH 2/2] Remove prototypes of nand_init() in favor of including nand.h Scott Wood
2008-07-01 14:43 ` Jens Gehrlein [this message]
2008-07-01 15:07 ` Scott Wood
2008-07-02 5:28 ` Jens Gehrlein
2008-07-09 21:52 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486A4282.2080102@tqs.de \
--to=sew_s@tqs.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox