From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Wed, 02 Jul 2008 09:21:32 -0700 Subject: [U-Boot-Users] [PATCH][resubmit] AX88180: new gigabit network driver In-Reply-To: <008401c8dc36$ee097100$0100a8c0@louis> References: <003f01c8db64$76c343a0$0100a8c0@louis> <486B2930.30404@qstreams.com> <008401c8dc36$ee097100$0100a8c0@louis> Message-ID: <486BAB0C.1090206@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Louis wrote: > Dear Ben, > > Thanks for your suggestion; I will correct the driver as soon as > possible. > And I make a mistake in sending the mail through outlook express, > hence making indentation problems. Great! Thanks Louis. For sending patches, I highly recommend using git-send-email instead of your mail client. While it's possible to get most clients to send properly formatted patches, it often takes a lot of trial and error, while git-send-email always works (AFAIK). Also, please consider running 'Lindent -pcs' on the code before sending. This page is very useful: http://www.denx.de/wiki/UBoot/CodingStyle regards, Ben