public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Fix printf errors.
Date: Wed, 02 Jul 2008 20:36:30 -0400	[thread overview]
Message-ID: <486C1F0E.1090803@gmail.com> (raw)
In-Reply-To: <200807021417.m62EHeff016508@pogo.cesa.opbu.xerox.com>

Andrew Klossner wrote:
> The compiler will help find mismatches between printf formats and
> arguments if you let it.  This patch adds the necessary attributes to
> declarations in include/common.h, then corrects the resulting compiler
> warnings in several files.  Some of these were bugs, e.g., "$d"
> instead of "%d" and incorrect arguments in common/cmd_fdt.c.  Others
> were just annoying, like int-long mismatches on a system where both
> are 32 bits.  It's worth fixing the annoying errors to catch the real
> ones.
> 
> I can only compile for ppc architecture so have not tested much of the
> source code for further warnings.
> 
> common/cmd_fdt.c

cmd_fdt.c portion...
Acked-by: Gerald Van Baren <vanbaren@cideas.com>

I'm embarrassed by the number of bugs I wrote into that function and 
apologize for being so sloppy.  My thanks to Andrew and others for 
finding and fixing my screwups.  :-(

Best regards,
gvb

  reply	other threads:[~2008-07-03  0:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-02 14:17 [U-Boot-Users] [PATCH] Fix printf errors Andrew Klossner
2008-07-03  0:36 ` Jerry Van Baren [this message]
2008-07-06 22:29 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=486C1F0E.1090803@gmail.com \
    --to=gvb.uboot@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox