From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH v2] net: Conditional COBJS inclusion of network drivers
Date: Sun, 06 Jul 2008 13:42:22 +0900 [thread overview]
Message-ID: <48704D2E.5080502@ruby.dti.ne.jp> (raw)
In-Reply-To: <20080705223203.17B71248DE@gemini.denx.de>
Wolfgang Denk wrote:
> Hm... Are you absolutely sure your changes, especially the
> CONFIG_CMD_NET and even more the CONFIG_NET_MULTI related ones, do not
> cause any trouble on any systems?
[...]
> It seems not obvious to me that your change is really harmless, or
> tested.
>
> Could you please comment?
Carefully reviewed as much as I could, but yes it's not fully tested.
I only did some build tests before patch submission.
I expect all board config files, which have one of the existing ethernet
driver config, already have CONFIG_CMD_NET and CONFIG_NET_MULTI, too.
But even if that is the case, there still might be some build breakage.
One of possible down sides of this change, upcomming ports or fully new
ports might encounter build failures due to missing symbols caused by
the lacks of libnet.a, command/cmd_bdinfo.o or something.
[ this could be easily fixed (and must be fixed at the end). ]
Avoiding unnecessary build failures like this, hence prefer the tight
coupling of net|driver|command configs, please revert the patch. Patch
seems already applied to upstream contrary to Wolfgang's comment.
Shinya
next prev parent reply other threads:[~2008-07-06 4:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-07 16:01 [U-Boot-Users] drivers/net/Makefile: Conditional COBJS inclusion cleanups Shinya Kuribayashi
2008-06-07 16:03 ` [U-Boot-Users] [PATCH 1/10] net: Conditional COBJS inclusion of bcm570x and tigon3 modules Shinya Kuribayashi
2008-06-07 16:04 ` [U-Boot-Users] [PATCH 2/10] net: Conditional COBJS inclusion of Realtek modules Shinya Kuribayashi
2008-06-07 16:06 ` [U-Boot-Users] [PATCH 3/10] net: Conditional COBJS inclusion of Intel modules Shinya Kuribayashi
2008-06-07 16:07 ` [U-Boot-Users] [PATCH 4/10] net: Conditional COBJS inclusion of INCA-IP switch Shinya Kuribayashi
2008-06-07 16:08 ` [U-Boot-Users] [PATCH 5/10] net: Conditional COBJS inclusion of National Semiconductor modules Shinya Kuribayashi
2008-06-07 16:10 ` [U-Boot-Users] [PATCH 6/10] net: Conditional COBJS inclusion of NET+ARM modules Shinya Kuribayashi
2008-06-07 16:11 ` [U-Boot-Users] [PATCH 7/10] net: Conditional COBJS inclusion of TSEC and Vitesse modules Shinya Kuribayashi
2008-06-07 16:12 ` [U-Boot-Users] [PATCH 8/10] net: Conditional COBJS inclusion of SMC modules Shinya Kuribayashi
2008-06-07 16:14 ` [U-Boot-Users] [PATCH 9/10] net: Conditional COBJS inclusion of Freescale FEC modules Shinya Kuribayashi
2008-06-07 16:16 ` [U-Boot-Users] [PATCH 10/10] net: Conditional COBJS inclusino of remainings Shinya Kuribayashi
2008-06-09 13:19 ` Ben Warren
2008-06-09 13:43 ` Shinya Kuribayashi
2008-06-09 14:37 ` [U-Boot-Users] [PATCH v2] net: Conditional COBJS inclusion of network drivers Shinya Kuribayashi
2008-07-05 22:32 ` Wolfgang Denk
2008-07-06 4:42 ` Shinya Kuribayashi [this message]
2008-07-06 10:56 ` Jean-Christophe PLAGNIOL-VILLARD
2008-07-07 1:20 ` Shinya Kuribayashi
2008-07-06 7:01 ` Ben Warren
2008-07-06 7:52 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48704D2E.5080502@ruby.dti.ne.jp \
--to=skuribay@ruby.dti.ne.jp \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox