public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] mips: When booting Linux images, add 'ethaddr' and 'eth1addr' to the environment
Date: Sun, 06 Jul 2008 14:59:08 +0900	[thread overview]
Message-ID: <48705F2C.4020406@ruby.dti.ne.jp> (raw)
In-Reply-To: <20080609035837.84DD36EACD@mcmullan-linux.hq.netapp.com>

Jason McMullan wrote:
> Add 'ethaddr' and 'eth1addr' to the Linux kernel environment if
> they are set in the U-Boot environment.

I missed this mail, sorry for my late reply.

Patch itself looks correct, but let me confirm.

Looking closely into linux/arch/*, I found that mips is the only
architecture which supports the 'ethaddr' kernel parameter.  Is this
right?  What I want to make sure is whether 'ethaddr' is an unusual
kernel parameter or not.

I think it's possible to probe MAC address(es) on kernel side, and it's
common practice IMO. [ if not so, Linux couldn't work without suitable
bootldrs which can pass the 'ethaddr' parameter. It's inconvenient, at
least for me. ]

However, I don't have strong opinions on this matter.  If you still have
troubles without this change, or can't probe MAC addresses by Kernel due
to some reason, I'll apply the patch.

Comments?


  Shinya

  reply	other threads:[~2008-07-06  5:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-09  3:56 [U-Boot-Users] [PATCH] mips: When booting Linux images, add 'ethaddr' and 'eth1addr' to the environment Jason McMullan
2008-07-06  5:59 ` Shinya Kuribayashi [this message]
2008-07-07 13:46   ` [U-Boot-Users] [PATCH] mips: When booting Linux images, add'ethaddr' " McMullan, Jason
2008-07-08 13:55     ` Shinya Kuribayashi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48705F2C.4020406@ruby.dti.ne.jp \
    --to=skuribay@ruby.dti.ne.jp \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox