From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Gehrlein Date: Tue, 08 Jul 2008 13:30:02 +0200 Subject: [U-Boot-Users] [PATCH 05/10] [ARM] TQMA31: add support for I2C, I2C temperature sensor and I2C-EEPROM In-Reply-To: <20080708103601.GD10985@game.jcrosoft.org> References: <20080704144552.12049.55374.stgit@tq-sewsrv-4.tq-net.de> <20080704145008.12049.42306.stgit@tq-sewsrv-4.tq-net.de> <20080708103601.GD10985@game.jcrosoft.org> Message-ID: <48734FBA.8070804@tqs.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Jean-Christophe PLAGNIOL-VILLARD schrieb: >> #if defined(CONFIG_DISPLAY_CPUINFO) >> int print_cpuinfo (void) >> { >> diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c >> index 6f9306f..68d2720 100644 >> --- a/drivers/i2c/mxc_i2c.c >> +++ b/drivers/i2c/mxc_i2c.c >> @@ -209,4 +209,17 @@ int i2c_write(uchar chip, uint addr, int alen, uchar *buf, int len) >> return 0; >> } >> >> +int i2c_get_bus_speed(void) >> +{ >> + return -1; >> +} >> + >> +int i2c_set_bus_speed (unsigned int speed) >> +{ >> + if (speed != CFG_I2C_SPEED) >> + return -1; >> + >> + return 0; >> +} > why do you refuse to change the i2c bus speed? Those two routines were missing at all before I started the board BSP. I just added them to compile the U-Boot successfully. Or did I miss something (e.g. overlaying-of-functions-technique or so)? I copied the source code from another driver (can't remember from where). It's no real excuse, I know. So, shall I change it or can I leave it for now? >> +#define CFG_I2C_SPEED 100000 > please use tab instead of whitespace >> +#define CFG_I2C_SLAVE 0 > please use tab instead of whitespace Will do. Thank you. Kind regards, Jens