From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Tue, 08 Jul 2008 13:33:36 +0200
Subject: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board
 with i.MX31 processor
In-Reply-To: <mailman.707077.1215511129.5026.u-boot-users@lists.sourceforge.net>
References: <mailman.707077.1215511129.5026.u-boot-users@lists.sourceforge.net>
Message-ID: <48735090.4060606@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Jens,

one comment to your patch:

Jens Gehrlein wrote:

> Signed-off-by: Jens Gehrlein <sew_s@tqs.de>
> ---
>
> Fixed two bugs:
> a) added NFS mount option "rw" to default environment
> b) added prefix $(obj) in front of .depend in Makefile. Thank you Magnus for catching that.
>   
[...]
> +
> +/*******************************************************************************
> + * Environment
> + ******************************************************************************/
> +
> +#define CONFIG_BOOTDELAY		4
> +
> +/* Default values */
> +#define CONFIG_NETMASK			255.255.255.0
> +#define CONFIG_IPADDR			172.20.5.100
> +#define CONFIG_SERVERIP			172.20.5.121
>   
Please delete this block. We do not accept such settings in default
config files.


bye,
Heiko

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany