From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Gehrlein Date: Tue, 08 Jul 2008 13:38:26 +0200 Subject: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor In-Reply-To: <48735090.4060606@denx.de> References: <48735090.4060606@denx.de> Message-ID: <487351B2.6060809@tqs.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Heiko, Heiko Schocher schrieb: > Hello Jens, > > one comment to your patch: > > Jens Gehrlein wrote: > >> Signed-off-by: Jens Gehrlein >> --- >> >> Fixed two bugs: >> a) added NFS mount option "rw" to default environment >> b) added prefix $(obj) in front of .depend in Makefile. Thank you Magnus for catching that. >> > [...] >> + >> +/******************************************************************************* >> + * Environment >> + ******************************************************************************/ >> + >> +#define CONFIG_BOOTDELAY 4 >> + >> +/* Default values */ >> +#define CONFIG_NETMASK 255.255.255.0 >> +#define CONFIG_IPADDR 172.20.5.100 >> +#define CONFIG_SERVERIP 172.20.5.121 >> > Please delete this block. We do not accept such settings in default > config files. To understand you properly: do you mean the defines for netmask, ipaddr and serverip, i.e. bootdelay and headerline are okay? I ask, because you quoted the upper lines, too. Kind regards, Jens