public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/6] sbc8560: proper definitions for TSEC.
Date: Wed, 09 Jul 2008 10:38:13 -0700	[thread overview]
Message-ID: <4874F785.3080907@gmail.com> (raw)
In-Reply-To: <8d54b96045b1f7a8504ca65177aeb92c6bc352f6.1215557132.git.paul.gortmaker@windriver.com>

Paul Gortmaker wrote:
> The definitions for the TSEC have become out of date.  There is no
> longer any such options like "CONFIG_MPC85xx_TSEC1" or similar.
> Update to match those of other boards, like the MPC8560ADS.
> ---
>   
You forgot your signed-off-by.  When you resubmit, add:

Acked-by: Ben Warren <biggerbadderben@gmail.com>
>  include/configs/sbc8560.h |   32 ++++++++++++++++++++++----------
>  1 files changed, 22 insertions(+), 10 deletions(-)
>
> diff --git a/include/configs/sbc8560.h b/include/configs/sbc8560.h
> index 146eafe..f07fbc0 100644
> --- a/include/configs/sbc8560.h
> +++ b/include/configs/sbc8560.h
> @@ -215,16 +215,28 @@
>  #define CFG_PCI_MEM_PHYS	0xC0000000
>  #define CFG_PCI_MEM_SIZE	0x10000000
>  
> -#if defined(CONFIG_TSEC_ENET)		/* TSEC Ethernet port */
> -
> -#  define CONFIG_NET_MULTI	1
> -#  define CONFIG_MII		1	/* MII PHY management		*/
> -#  define CONFIG_MPC85xx_TSEC1
> -#  define CONFIG_MPC85xx_TSEC1_NAME	"TSEC0"
> -#  define TSEC1_PHY_ADDR	25
> -#  define TSEC1_PHYIDX		0
> -/* Options are: TSEC0 */
> -#  define CONFIG_ETHPRIME		"TSEC0"
> +#ifdef CONFIG_TSEC_ENET
> +
> +#ifndef CONFIG_NET_MULTI
> +#define CONFIG_NET_MULTI 	1
> +#endif
> +
> +#ifndef CONFIG_MII
> +#define CONFIG_MII		1	/* MII PHY management */
> +#endif
> +#define CONFIG_TSEC1	1
> +#define CONFIG_TSEC1_NAME	"TSEC0"
> +#define CONFIG_TSEC2	1
> +#define CONFIG_TSEC2_NAME	"TSEC1"
> +#define TSEC1_PHY_ADDR		0x19
> +#define TSEC2_PHY_ADDR		0x1a
> +#define TSEC1_PHYIDX		0
> +#define TSEC2_PHYIDX		0
> +#define TSEC1_FLAGS		TSEC_GIGABIT
> +#define TSEC2_FLAGS		TSEC_GIGABIT
> +
> +/* Options are: TSEC[0-1] */
> +#define CONFIG_ETHPRIME		"TSEC0"
>  
>  #elif defined(CONFIG_ETHER_ON_FCC)	/* CPM FCC Ethernet */
>  
>   

  parent reply	other threads:[~2008-07-09 17:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-09 17:27 [U-Boot-Users] [PATCH 0/6] Update sbc8560; enable fdt/powerpc support Paul Gortmaker
2008-07-09 17:27 ` [U-Boot-Users] [PATCH 1/6] sbc8560: proper definitions for TSEC Paul Gortmaker
2008-07-09 17:27   ` [U-Boot-Users] [PATCH 2/6] sbc8560: properly set cs0_bnds for 512MB Paul Gortmaker
2008-07-09 17:27     ` [U-Boot-Users] [PATCH 3/6] sbc8560: define eth0 and eth1 instead of eth1 and eth2 Paul Gortmaker
2008-07-09 17:27       ` [U-Boot-Users] [PATCH 4/6] sbc8560: add in ft_board_setup() Paul Gortmaker
2008-07-09 17:27         ` [U-Boot-Users] [PATCH 5/6] sbc8560: add default fdt values Paul Gortmaker
2008-07-09 17:27           ` [U-Boot-Users] [PATCH 6/6] sbc8560: enable CONFIG_OF_LIBFDT by default Paul Gortmaker
2008-07-09 17:40       ` [U-Boot-Users] [PATCH 3/6] sbc8560: define eth0 and eth1 instead of eth1 and eth2 Ben Warren
2008-07-09 21:29         ` Paul Gortmaker
2008-07-09 21:51           ` Ben Warren
2008-07-09 17:38   ` Ben Warren [this message]
2008-07-09 17:56     ` [U-Boot-Users] [PATCH 1/6] sbc8560: proper definitions for TSEC Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4874F785.3080907@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox