public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] at91: Fix to enable using Teridian MII phy (78Q21x3) with at91sam9260
Date: Thu, 10 Jul 2008 01:00:51 +0200	[thread overview]
Message-ID: <48754323.3050000@denx.de> (raw)
In-Reply-To: <4874B6AF.40400@feig.de>

Manuel Sahm wrote:

> if I apply the patch with:
> 
> patch -p1 < patchat91.diff
> 
> some messages occur, is this correct ?
> 
> 
> (Stripping trailing CRs from patch.)
> patching file board/atmel/at91sam9260ek/at91sam9260ek.c
> patch unexpectedly ends in middle of line
> Hunk #1 succeeded at 183 with fuzz 2 (offset -5 lines).

it is very likely that these messages occur because the patch
was incorrectly saved from the email body. This patch applies
cleanly against top of our u-boot git tree.
 
> The description is correct - PA23 and PA24 are connected to the TWI
> EEPROM an the DevBoard at91sam9260ek.
> The patch works well.
> Here the signed-off line:
> 
> Signed-off-by: Manuel Sahm <Manuel.Sahm@feig.de>

Thanks, I will repost the patch again.

> Another problem is, that the same error is in the official kernel tree
> in the file at91sam9260ek_devices.c ?!
> Although the error is still in the kernel, a modification of the uboot
> file at91sam9260ek.c is enough to get ethernet working ?

if the kernel resets Peripheral B pin configuration, then
ethernet will stop working, I think. This should be fixed in
the kernel code, too.

Best regards,
Anatolij

  parent reply	other threads:[~2008-07-09 23:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-10  9:56 [U-Boot-Users] Teridian Phy Support tr78q21x3 Manuel Sahm
2008-06-10 20:35 ` Anatolij Gustschin
2008-06-11  6:25   ` Manuel Sahm
2008-06-11  7:43     ` Anatolij Gustschin
2008-06-18  7:39       ` Manuel Sahm
2008-06-18  7:59         ` Wolfgang Denk
2008-07-08  8:03         ` [U-Boot-Users] [PATCH] at91: Fix to enable using Teridian MII phy (78Q21x3) with at91sam9260 Anatolij Gustschin
     [not found]           ` <4874B6AF.40400@feig.de>
2008-07-09 23:00             ` Anatolij Gustschin [this message]
2008-07-10  6:34               ` Manuel Sahm
2008-07-09 23:15           ` [U-Boot-Users] [PATCH v2] " Anatolij Gustschin
2008-07-09 23:29             ` Ben Warren
2008-07-13 12:42             ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48754323.3050000@denx.de \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox