From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH v2] at91: Fix to enable using Teridian MII phy (78Q21x3) with at91sam9260
Date: Wed, 09 Jul 2008 16:29:53 -0700 [thread overview]
Message-ID: <487549F1.4070805@gmail.com> (raw)
In-Reply-To: <4875467E.1080900@denx.de>
Anatolij Gustschin wrote:
> On the at91sam9260ep development board there is an EEPROM
> connected to the TWI interface (PA23, PA24 Peripheral A
> multiplexing), so we cannot use these pins as ETX2, ETX3.
> This patch configures PA10, PA11 pins for ETX2, ETX3
> instead of PA23, PA24 pins.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Signed-off-by: Manuel Sahm <Manuel.Sahm@feig.de>
> ---
> board/atmel/at91sam9260ek/at91sam9260ek.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/board/atmel/at91sam9260ek/at91sam9260ek.c b/board/atmel/at91sam9260ek/at91sam9260ek.c
> index 836a0c4..06d8512 100644
> --- a/board/atmel/at91sam9260ek/at91sam9260ek.c
> +++ b/board/atmel/at91sam9260ek/at91sam9260ek.c
> @@ -188,8 +188,17 @@ static void at91sam9260ek_macb_hw_init(void)
> at91_set_B_periph(AT91_PIN_PA25, 0); /* ERX2 */
> at91_set_B_periph(AT91_PIN_PA26, 0); /* ERX3 */
> at91_set_B_periph(AT91_PIN_PA27, 0); /* ERXCK */
> +#if defined(CONFIG_AT91SAM9260EK)
>
There's a weakness in your software architecture if there are two
compile paths in 'at91sam9260ek.c': one that has CONFIG_AT91SAM9260EK
and one that doesn't. Maybe time for a new board variant or some file
re-naming?
regards,
Ben
next prev parent reply other threads:[~2008-07-09 23:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 9:56 [U-Boot-Users] Teridian Phy Support tr78q21x3 Manuel Sahm
2008-06-10 20:35 ` Anatolij Gustschin
2008-06-11 6:25 ` Manuel Sahm
2008-06-11 7:43 ` Anatolij Gustschin
2008-06-18 7:39 ` Manuel Sahm
2008-06-18 7:59 ` Wolfgang Denk
2008-07-08 8:03 ` [U-Boot-Users] [PATCH] at91: Fix to enable using Teridian MII phy (78Q21x3) with at91sam9260 Anatolij Gustschin
[not found] ` <4874B6AF.40400@feig.de>
2008-07-09 23:00 ` Anatolij Gustschin
2008-07-10 6:34 ` Manuel Sahm
2008-07-09 23:15 ` [U-Boot-Users] [PATCH v2] " Anatolij Gustschin
2008-07-09 23:29 ` Ben Warren [this message]
2008-07-13 12:42 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487549F1.4070805@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox