From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Wed, 09 Jul 2008 16:29:53 -0700 Subject: [U-Boot-Users] [PATCH v2] at91: Fix to enable using Teridian MII phy (78Q21x3) with at91sam9260 In-Reply-To: <4875467E.1080900@denx.de> References: <484E4FC8.9000004@feig.de> <484EE57C.3070603@denx.de> <484F6FD3.5050003@feig.de> <484F8220.1050606@denx.de> <4858BB99.8020703@feig.de> <48731F50.7030802@denx.de> <4875467E.1080900@denx.de> Message-ID: <487549F1.4070805@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Anatolij Gustschin wrote: > On the at91sam9260ep development board there is an EEPROM > connected to the TWI interface (PA23, PA24 Peripheral A > multiplexing), so we cannot use these pins as ETX2, ETX3. > This patch configures PA10, PA11 pins for ETX2, ETX3 > instead of PA23, PA24 pins. > > Signed-off-by: Anatolij Gustschin > Signed-off-by: Manuel Sahm > --- > board/atmel/at91sam9260ek/at91sam9260ek.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/board/atmel/at91sam9260ek/at91sam9260ek.c b/board/atmel/at91sam9260ek/at91sam9260ek.c > index 836a0c4..06d8512 100644 > --- a/board/atmel/at91sam9260ek/at91sam9260ek.c > +++ b/board/atmel/at91sam9260ek/at91sam9260ek.c > @@ -188,8 +188,17 @@ static void at91sam9260ek_macb_hw_init(void) > at91_set_B_periph(AT91_PIN_PA25, 0); /* ERX2 */ > at91_set_B_periph(AT91_PIN_PA26, 0); /* ERX3 */ > at91_set_B_periph(AT91_PIN_PA27, 0); /* ERXCK */ > +#if defined(CONFIG_AT91SAM9260EK) > There's a weakness in your software architecture if there are two compile paths in 'at91sam9260ek.c': one that has CONFIG_AT91SAM9260EK and one that doesn't. Maybe time for a new board variant or some file re-naming? regards, Ben