[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Ricardo]

Hi List:

 This is my first contribution to u-boot. I have ported u-boot to the
ML507 Board by Xilinx.
http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm

This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.

The port supports:
    -Virtex 5 ppc440x5
    -XIlinx Interrupt Controller
    -Xilinx I2C Controller (Interrupted mode)
    -Xilinx Uart Lite (simple port)
    -Xilinx LL_TEMA (Interrupted and SGDMA)
    -Save environment on board eeprom
    -DTT support for the ADT sensor on board (new hwmon driver)
    -Dummy I2C driver (for testing purposes)

This patch works against the last commit to the p4xx branch.

I am a researcher of the Universidad Autonoma de Madrid, and this work
has been supported by Q-Technology ( http://qtec.com ) under a
Research Agreement.

Any comment will be very welcomed.

PS: I have divided the patch in four parts for the mailing list
-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ml507_1_of_4.diff.bz2
Type: application/x-bzip2
Size: 26018 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080710/ae3703a3/attachment.bin 

[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Ricardo]

Part 2

On Thu, Jul 10, 2008 at 6:06 PM, Ricardo <ricardo.ribalda@gmail.com> wrote:
> Hi List:
>
>  This is my first contribution to u-boot. I have ported u-boot to the
> ML507 Board by Xilinx.
> http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm
>
> This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.
>
> The port supports:
>    -Virtex 5 ppc440x5
>    -XIlinx Interrupt Controller
>    -Xilinx I2C Controller (Interrupted mode)
>    -Xilinx Uart Lite (simple port)
>    -Xilinx LL_TEMA (Interrupted and SGDMA)
>    -Save environment on board eeprom
>    -DTT support for the ADT sensor on board (new hwmon driver)
>    -Dummy I2C driver (for testing purposes)
>
> This patch works against the last commit to the p4xx branch.
>
> I am a researcher of the Universidad Autonoma de Madrid, and this work
> has been supported by Q-Technology ( http://qtec.com ) under a
> Research Agreement.
>
> Any comment will be very welcomed.
>
> PS: I have divided the patch in four parts for the mailing list
> --
> Ricardo Ribalda
> http://www.eps.uam.es/~rribalda/
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ml507_2_of_4.diff.bz2
Type: application/x-bzip2
Size: 27092 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080710/bf422484/attachment.bin 

[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Ricardo]

Part 3

On Thu, Jul 10, 2008 at 6:07 PM, Ricardo <ricardo.ribalda@gmail.com> wrote:
> Part 2
>
> On Thu, Jul 10, 2008 at 6:06 PM, Ricardo <ricardo.ribalda@gmail.com> wrote:
>> Hi List:
>>
>>  This is my first contribution to u-boot. I have ported u-boot to the
>> ML507 Board by Xilinx.
>> http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm
>>
>> This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.
>>
>> The port supports:
>>    -Virtex 5 ppc440x5
>>    -XIlinx Interrupt Controller
>>    -Xilinx I2C Controller (Interrupted mode)
>>    -Xilinx Uart Lite (simple port)
>>    -Xilinx LL_TEMA (Interrupted and SGDMA)
>>    -Save environment on board eeprom
>>    -DTT support for the ADT sensor on board (new hwmon driver)
>>    -Dummy I2C driver (for testing purposes)
>>
>> This patch works against the last commit to the p4xx branch.
>>
>> I am a researcher of the Universidad Autonoma de Madrid, and this work
>> has been supported by Q-Technology ( http://qtec.com ) under a
>> Research Agreement.
>>
>> Any comment will be very welcomed.
>>
>> PS: I have divided the patch in four parts for the mailing list
>> --
>> Ricardo Ribalda
>> http://www.eps.uam.es/~rribalda/
>>
>
>
>
> --
> Ricardo Ribalda
> http://www.eps.uam.es/~rribalda/
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ml507_3_of_4.diff.bz2
Type: application/x-bzip2
Size: 26490 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080710/6971f602/attachment.bin 

[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Ricardo]

And Part  4

On Thu, Jul 10, 2008 at 6:07 PM, Ricardo <ricardo.ribalda@gmail.com> wrote:
> Part 3
>
> On Thu, Jul 10, 2008 at 6:07 PM, Ricardo <ricardo.ribalda@gmail.com> wrote:
>> Part 2
>>
>> On Thu, Jul 10, 2008 at 6:06 PM, Ricardo <ricardo.ribalda@gmail.com> wrote:
>>> Hi List:
>>>
>>>  This is my first contribution to u-boot. I have ported u-boot to the
>>> ML507 Board by Xilinx.
>>> http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm
>>>
>>> This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.
>>>
>>> The port supports:
>>>    -Virtex 5 ppc440x5
>>>    -XIlinx Interrupt Controller
>>>    -Xilinx I2C Controller (Interrupted mode)
>>>    -Xilinx Uart Lite (simple port)
>>>    -Xilinx LL_TEMA (Interrupted and SGDMA)
>>>    -Save environment on board eeprom
>>>    -DTT support for the ADT sensor on board (new hwmon driver)
>>>    -Dummy I2C driver (for testing purposes)
>>>
>>> This patch works against the last commit to the p4xx branch.
>>>
>>> I am a researcher of the Universidad Autonoma de Madrid, and this work
>>> has been supported by Q-Technology ( http://qtec.com ) under a
>>> Research Agreement.
>>>
>>> Any comment will be very welcomed.
>>>
>>> PS: I have divided the patch in four parts for the mailing list
>>> --
>>> Ricardo Ribalda
>>> http://www.eps.uam.es/~rribalda/
>>>
>>
>>
>>
>> --
>> Ricardo Ribalda
>> http://www.eps.uam.es/~rribalda/
>>
>
>
>
> --
> Ricardo Ribalda
> http://www.eps.uam.es/~rribalda/
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ml507_4_of_4.diff.bz2
Type: application/x-bzip2
Size: 23729 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080710/8e423347/attachment.bin 

[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Wolfgang Denk]

In message <aa76a2be0807100907q689ea6b8o17ecd67dbaadd1bd@mail.gmail.com> you wrote:
> 
> And Part  4

Could you please explain why the subject says part 1, and the
message body says part 4 ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Computers make excellent and efficient servants, but I have  no  wish
to  serve under them. Captain, a starship also runs on loyalty to one
man. And nothing can replace it or him.
	-- Spock, "The Ultimate Computer", stardate 4729.4

[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Ricardo]

Hello Wolfgang

  I wanted the four parts to have the same subject, to easy the
handling of the files. The first submition was 4 .bz2 dependent
files... But later on the evening I have prepared 8 different
INdependent patches following the guidelines on the u-boot site. Sorry
for the mess. I have sent some minutes ago an apologize and a
explanation. Please check it if you have enough time. It is my first
time with git, and I am a bit confused (even after a day of reading)


 Best regards and thanks

On Thu, Jul 10, 2008 at 8:18 PM, Wolfgang Denk <wd@denx.de> wrote:
> In message <aa76a2be0807100907q689ea6b8o17ecd67dbaadd1bd@mail.gmail.com> you wrote:
>>
>> And Part  4
>
> Could you please explain why the subject says part 1, and the
> message body says part 4 ?
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Computers make excellent and efficient servants, but I have  no  wish
> to  serve under them. Captain, a starship also runs on loyalty to one
> man. And nothing can replace it or him.
>        -- Spock, "The Ultimate Computer", stardate 4729.4
>
> -------------------------------------------------------------------------
> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
> Studies have shown that voting for your favorite open source project,
> along with a healthy diet, reduces your potential for chronic lameness
> and boredom. Vote Now at http://www.sourceforge.net/community/cca08
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Wolfgang Denk]

In message <aa76a2be0807101125k318f21bet187325afd4dca898@mail.gmail.com> you wrote:
> 
>   I wanted the four parts to have the same subject, to easy the

But this makes no sense, especiall when you add "1/4" to the subject.

> handling of the files. The first submition was 4 .bz2 dependent
> files... But later on the evening I have prepared 8 different
> INdependent patches following the guidelines on the u-boot site. Sorry

The guidelines say:

	...
	Separate _logical changes_ into a single patch file.

	...
	No MIME, no links, no compression, no attachments.  Just plain
	text.

	...
	The canonical patch subject line is: 

	    Subject: [PATCH 001/123] subsystem: summary phrase
	...


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A princess should not be afraid -- not with a brave knight to protect
her.
	-- McCoy, "Shore Leave", stardate 3025.3

[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Wolfgang Denk]

In message <aa76a2be0807100906j431116bep297eba170a209dd5@mail.gmail.com> you wrote:
>
> Any comment will be very welcomed.
> 
> PS: I have divided the patch in four parts for the mailing list

Soerry, I can neither read nor apply this conveniently:

> Content-Type: application/x-bzip2; name=ml507_1_of_4.diff.bz2
> Content-Transfer-Encoding: base64
> X-Attachment-Id: f_fihjyhy70
> Content-Disposition: attachment; filename=ml507_1_of_4.diff.bz2
> 
> QlpoOTFBWSZTWSR6xsAAgHH/gH/6/////////////r////9gkx749nwE919zr26feb708npH3fPa
> Pab6z7Ye+2gXd9t2vvvvHe+c3uzjhUa33venYaAvm+vPfd6vu856FHWmNq+nTqjVsqlW2WtUaapE
> egaKoXWjbQAoBQpa1De7y5295t3nPR6CB3tPvoBvWoXEj5L593r7fPglW+19xvu+c+++fd73b2fK
> D199c0D6+AczIa31pTs1PRtgegHQuwBkK9GgAUsTAUgJ9BlXQUA3hAJnfe+cd73Xe6r25vHWVNsp
> dn3NF751a4W2te3OqXbrtp10uO3Ve995xV7BoqiIAfb573fZod6XVLa7pNVjPrc73qoESpOjlKk7
> LtkO3ffFvvRfC5OMotZS0a99j15arBRaxb6xHZQa0c7VtqcmVW1jaM7VdGDRUOZRKnR4eqSqlCns
> cezurEPvtPT0CrODK202x9Wzs9x6F5ltl6oy6fe+T4eEoICBohoRpoQwo00aaKep+iekaNCm9U0/
...

Please make sure to post plain text patches only, and keep in mind
that the mailing list has a soft limit of 40 kB message size , and a
hard limit of 100 kB.

See http://www.denx.de/wiki/UBoot/Patches

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There are three principal ways to lose money: wine, women,  and  en-
gineers.  While  the first two are more pleasant, the third is by far
the more certain."                      -- Baron Rothschild, ca. 1800

[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Michal Simek]

Hi Ricardo,

I read your patches in your weird style. 
These style of patches never go to mainline. You use xilinx generated files which is currently use only with ml300.
For example look at your xparameters.h there are a lot of values which are not used.
If you want to add ml507 to mainline U-BOOT you have to change completely handling style of xilinx board for ppc.
In next U-BOOT release I will clean ancient ml300. I want to remove a lot of xilinx generic files.

100% NACK for these patches.

The size of patches is due to your incorrect design strategy.

Michal Simek


Hi List:

 This is my first contribution to u-boot. I have ported u-boot to the
ML507 Board by Xilinx.
http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm

This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.

The port supports:
    -Virtex 5 ppc440x5
    -XIlinx Interrupt Controller
    -Xilinx I2C Controller (Interrupted mode)
    -Xilinx Uart Lite (simple port)
    -Xilinx LL_TEMA (Interrupted and SGDMA)
    -Save environment on board eeprom
    -DTT support for the ADT sensor on board (new hwmon driver)
    -Dummy I2C driver (for testing purposes)

This patch works against the last commit to the p4xx branch.

I am a researcher of the Universidad Autonoma de Madrid, and this work
has been supported by Q-Technology ( http://qtec.com ) under a
Research Agreement.

Any comment will be very welcomed.

PS: I have divided the patch in four parts for the mailing list
-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Ricardo]

Hi Michael

  Sorry to hear that. I have tried to give all my best and follow the
style of the ml300 board, which was the closest board to mine.
On FPGAs board I think that it is not  a horrible idea to follow this
style. Maybe you should consider to create an FPGA branch, where the
generic drivers could be accepted. As I said, the FPGA hardware
changes a lot and support a so changing hardware will be very
difficult... Or just should not support FPGAs and its IP devices...


By the way:

  patches 1 2  and 6 follow the guidelines and don't add any generic driver
  patches 8 (except xparameters.h) follow the guidelines
  patch 6 could be redesined. You should be aware that
driver/serial/serial_xuartlite.c does not compile for ppc440 without
that patch


  Best regards

On Thu, Jul 10, 2008 at 9:04 PM, Michal Simek <Monstr@seznam.cz> wrote:
> Hi Ricardo,
>
> I read your patches in your weird style.
> These style of patches never go to mainline. You use xilinx generated files which is currently use only with ml300.
> For example look at your xparameters.h there are a lot of values which are not used.
> If you want to add ml507 to mainline U-BOOT you have to change completely handling style of xilinx board for ppc.
> In next U-BOOT release I will clean ancient ml300. I want to remove a lot of xilinx generic files.
>
> 100% NACK for these patches.
>
> The size of patches is due to your incorrect design strategy.
>
> Michal Simek
>
>
> Hi List:
>
>  This is my first contribution to u-boot. I have ported u-boot to the
> ML507 Board by Xilinx.
> http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm
>
> This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.
>
> The port supports:
>    -Virtex 5 ppc440x5
>    -XIlinx Interrupt Controller
>    -Xilinx I2C Controller (Interrupted mode)
>    -Xilinx Uart Lite (simple port)
>    -Xilinx LL_TEMA (Interrupted and SGDMA)
>    -Save environment on board eeprom
>    -DTT support for the ADT sensor on board (new hwmon driver)
>    -Dummy I2C driver (for testing purposes)
>
> This patch works against the last commit to the p4xx branch.
>
> I am a researcher of the Universidad Autonoma de Madrid, and this work
> has been supported by Q-Technology ( http://qtec.com ) under a
> Research Agreement.
>
> Any comment will be very welcomed.
>
> PS: I have divided the patch in four parts for the mailing list
> --
> Ricardo Ribalda
> http://www.eps.uam.es/~rribalda/
>
>
>



-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Wolfgang Denk]

Dear Ricardo,

in message <aa76a2be0807101219s4946b744h2ca925f1e9c7dbf8@mail.gmail.com> you wrote:
> 
>   Sorry to hear that. I have tried to give all my best and follow the
> style of the ml300 board, which was the closest board to mine.
> On FPGAs board I think that it is not  a horrible idea to follow this
> style. Maybe you should consider to create an FPGA branch, where the
> generic drivers could be accepted. As I said, the FPGA hardware

Believe me, this makes no sense. Copying the same files around quickly
results in an unmaintainable mess. Adding lots of code which are not
actually needed just prevent anybody from actually understanding which
code is essential and which not.

We've been there before, and we learned this lesson.

> changes a lot and support a so changing hardware will be very
> difficult... Or just should not support FPGAs and its IP devices...

I do not think that FPGA have any inherent  problems.  The  issue  is
with  the  base  code  which  was  not written with a boot loader (or
portability and efficiency) in mind.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A weak mind is like a microscope, which magnifies trifling things,
but cannot receive great ones.      -- Philip Earl of Chesterfield

[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Ricardo]

Hello Wolfgang

  Lets find a solution to support ML507 on u-boot (and make my work
availiable to more people). I am completly with you about the low
quality of the xilinx-adapted code. I am using it for two things: i2c
and ethernet, but the board can perfetly work without them.  The i2c
code can be very simply adapted to the "good way".

  Tomorrow I will work on a patch for the CPU, ADT7640, Uart Lite and
the board without i2c and in the near future I will provide a "clean"
driver for the xilinx i2c.

  How does it sounds for you?


       Best regards


-- 
Ricardo Ribalda
http://www.eps.uam.es/~rribalda/

[U-Boot-Users] [PATCH] Support fot the ML507 Board 1/4

[Michal Simek]

Hi Ricardo,

> Hi Michael
> 
>   Sorry to hear that. I have tried to give all my best and follow the
> style of the ml300 board, which was the closest board to mine.
> On FPGAs board I think that it is not  a horrible idea to follow this
> style. Maybe you should consider to create an FPGA branch, where the
> generic drivers could be accepted. As I said, the FPGA hardware
> changes a lot and support a so changing hardware will be very
> difficult... Or just should not support FPGAs and its IP devices...

Any FPGA branch is not acceptable in U-BOOT mainline. Mainline U-BOOT is only
one. If you want to add your changes to U-BOOT mainline you have to change your
design style.

> By the way:
> 
>   patches 1 2  and 6 follow the guidelines and don't add any generic driver
>   patches 8 (except xparameters.h) follow the guidelines
>   patch 6 could be redesined. You should be aware that
> driver/serial/serial_xuartlite.c does not compile for ppc440 without
> that patch

This should be truth but without compatible board doesn't make sense to me. You
use any numbers but I haven't seen these numbers anywhere. Please use git for
your work and use more generic subject of your email. In set of patches you use
conventional style which generate git. Add there at the begging ml507 or xilinx
or whatever what will be specify xilinx relate topic.

Michal

>   Best regards
> 
> On Thu, Jul 10, 2008 at 9:04 PM, Michal Simek <Monstr@seznam.cz> wrote:
>> Hi Ricardo,
>>
>> I read your patches in your weird style.
>> These style of patches never go to mainline. You use xilinx generated files which is currently use only with ml300.
>> For example look at your xparameters.h there are a lot of values which are not used.
>> If you want to add ml507 to mainline U-BOOT you have to change completely handling style of xilinx board for ppc.
>> In next U-BOOT release I will clean ancient ml300. I want to remove a lot of xilinx generic files.
>>
>> 100% NACK for these patches.
>>
>> The size of patches is due to your incorrect design strategy.
>>
>> Michal Simek
>>
>>
>> Hi List:
>>
>>  This is my first contribution to u-boot. I have ported u-boot to the
>> ML507 Board by Xilinx.
>> http://www.xilinx.com/products/devkits/HW-V5-ML507-UNI-G.htm
>>
>> This boards includes an FPGA Virtex 5 FX with an embedded PowerPC 440.
>>
>> The port supports:
>>    -Virtex 5 ppc440x5
>>    -XIlinx Interrupt Controller
>>    -Xilinx I2C Controller (Interrupted mode)
>>    -Xilinx Uart Lite (simple port)
>>    -Xilinx LL_TEMA (Interrupted and SGDMA)
>>    -Save environment on board eeprom
>>    -DTT support for the ADT sensor on board (new hwmon driver)
>>    -Dummy I2C driver (for testing purposes)
>>
>> This patch works against the last commit to the p4xx branch.
>>
>> I am a researcher of the Universidad Autonoma de Madrid, and this work
>> has been supported by Q-Technology ( http://qtec.com ) under a
>> Research Agreement.
>>
>> Any comment will be very welcomed.
>>
>> PS: I have divided the patch in four parts for the mailing list
>> --
>> Ricardo Ribalda
>> http://www.eps.uam.es/~rribalda/
>>
>>
>>
> 
> 
>