From: Wolfgang Grandegger <wg@grandegger.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] V3: mpc85xx set CCB:LBC ratio (CONFIG_LBC_CLOCK_RATIO)
Date: Fri, 11 Jul 2008 11:55:46 +0200 [thread overview]
Message-ID: <48772E22.1070303@grandegger.com> (raw)
In-Reply-To: <86od54ahu8.fsf_-_@johno-ibook.fn.ogness.net>
John Ogness wrote:
> I've changed the patch so that it is less intrusive. It now simply
> adds the new function to the "init_sequence" if defined.
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Could you please send your patches inline next time to simplify
reviewing? Thanks.
I have a general remark here. Currently, various 85xx boards setup the
local bus in the board specific code called from checkboard(). Your
set_lbc_clock_ratio() would be called earlier and is therefore unusable
for these board. Nevertheless, the setting of the clock rate is just one
thing to be done to setup the local bus properly but there are more
including bug fixes. I would appreciate a generic function for that
purpose to get rid of duplicated code.
Wolfgang.
prev parent reply other threads:[~2008-07-11 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 13:01 [U-Boot-Users] PATCH: mpc85xx set lcb clock (CONFIG_CCB_CLCKDIV) John Ogness
2008-07-07 11:54 ` [U-Boot-Users] PATCH: (ver. 2) mpc85xx set CCB:LBC ratio (CONFIG_LBC_CLOCK_RATIO) John Ogness
2008-07-11 9:30 ` [U-Boot-Users] [PATCH] V3: " John Ogness
2008-07-11 9:55 ` Wolfgang Grandegger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48772E22.1070303@grandegger.com \
--to=wg@grandegger.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox