* [U-Boot-Users] PATCH: mpc85xx set lcb clock (CONFIG_CCB_CLCKDIV)
@ 2008-07-04 13:01 John Ogness
2008-07-07 11:54 ` [U-Boot-Users] PATCH: (ver. 2) mpc85xx set CCB:LBC ratio (CONFIG_LBC_CLOCK_RATIO) John Ogness
0 siblings, 1 reply; 4+ messages in thread
From: John Ogness @ 2008-07-04 13:01 UTC (permalink / raw)
To: u-boot
A non-text attachment was scrubbed...
Name: mpc85xx_set_lcb.patch
Type: text/x-diff
Size: 1377 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080704/66bc259c/attachment.patch
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot-Users] PATCH: (ver. 2) mpc85xx set CCB:LBC ratio (CONFIG_LBC_CLOCK_RATIO)
2008-07-04 13:01 [U-Boot-Users] PATCH: mpc85xx set lcb clock (CONFIG_CCB_CLCKDIV) John Ogness
@ 2008-07-07 11:54 ` John Ogness
2008-07-11 9:30 ` [U-Boot-Users] [PATCH] V3: " John Ogness
0 siblings, 1 reply; 4+ messages in thread
From: John Ogness @ 2008-07-07 11:54 UTC (permalink / raw)
To: u-boot
A non-text attachment was scrubbed...
Name: mpc85xx_set_lbc-v2.patch
Type: text/x-diff
Size: 1412 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080707/49a7f409/attachment.patch
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot-Users] [PATCH] V3: mpc85xx set CCB:LBC ratio (CONFIG_LBC_CLOCK_RATIO)
2008-07-07 11:54 ` [U-Boot-Users] PATCH: (ver. 2) mpc85xx set CCB:LBC ratio (CONFIG_LBC_CLOCK_RATIO) John Ogness
@ 2008-07-11 9:30 ` John Ogness
2008-07-11 9:55 ` Wolfgang Grandegger
0 siblings, 1 reply; 4+ messages in thread
From: John Ogness @ 2008-07-11 9:30 UTC (permalink / raw)
To: u-boot
A non-text attachment was scrubbed...
Name: patch-mpc85xx_set_lbc-v3.diff
Type: text/x-diff
Size: 1420 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080711/ed493295/attachment.diff
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot-Users] [PATCH] V3: mpc85xx set CCB:LBC ratio (CONFIG_LBC_CLOCK_RATIO)
2008-07-11 9:30 ` [U-Boot-Users] [PATCH] V3: " John Ogness
@ 2008-07-11 9:55 ` Wolfgang Grandegger
0 siblings, 0 replies; 4+ messages in thread
From: Wolfgang Grandegger @ 2008-07-11 9:55 UTC (permalink / raw)
To: u-boot
John Ogness wrote:
> I've changed the patch so that it is less intrusive. It now simply
> adds the new function to the "init_sequence" if defined.
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Could you please send your patches inline next time to simplify
reviewing? Thanks.
I have a general remark here. Currently, various 85xx boards setup the
local bus in the board specific code called from checkboard(). Your
set_lbc_clock_ratio() would be called earlier and is therefore unusable
for these board. Nevertheless, the setting of the clock rate is just one
thing to be done to setup the local bus properly but there are more
including bug fixes. I would appreciate a generic function for that
purpose to get rid of duplicated code.
Wolfgang.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-07-11 9:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-04 13:01 [U-Boot-Users] PATCH: mpc85xx set lcb clock (CONFIG_CCB_CLCKDIV) John Ogness
2008-07-07 11:54 ` [U-Boot-Users] PATCH: (ver. 2) mpc85xx set CCB:LBC ratio (CONFIG_LBC_CLOCK_RATIO) John Ogness
2008-07-11 9:30 ` [U-Boot-Users] [PATCH] V3: " John Ogness
2008-07-11 9:55 ` Wolfgang Grandegger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox