From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 3/7] sbc8560: define eth0 and eth1 instead of eth1 and eth2
Date: Fri, 11 Jul 2008 18:03:52 -0400 [thread overview]
Message-ID: <4877D8C8.7010300@windriver.com> (raw)
In-Reply-To: <20080711202420.C5DD524304@gemini.denx.de>
Wolfgang Denk wrote:
>
>
>> + * MAC addresses directly on it.
>> + */
>> +#if 0
>> +#define CONFIG_ETHADDR 00:01:af:07:9b:8a
>> +#define CONFIG_ETH1ADDR 00:01:af:07:9b:8b
>> #define CONFIG_SERVERIP 192.168.0.131
>> #define CONFIG_IPADDR 192.168.0.105
>> -#define CONFIG_GATEWAYIP 0.0.0.0
>> +#define CONFIG_GATEWAYIP 192.168.0.1
>> #define CONFIG_NETMASK 255.255.255.0
>> +#endif
>> +
>>
>
> I think this should be removed. There is really no good reason to add
> network configuration at all to the board config file (with the
> exception of the 2 or 3 boards which actually boot from real ROM).
>
No problem. I'll remove and resend.
Thanks,
Paul.
>
>
> Best regards,
>
> Wolfgang Denk
>
>
next prev parent reply other threads:[~2008-07-11 22:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 19:33 [U-Boot-Users] [PATCH 0/6] Update sbc8560; enable fdt/powerpc support Paul Gortmaker
2008-07-11 19:33 ` [U-Boot-Users] [PATCH 1/7] sbc8560: proper definitions for TSEC Paul Gortmaker
2008-07-11 19:33 ` [U-Boot-Users] [PATCH 2/7] sbc8560: properly set cs0_bnds for 512MB Paul Gortmaker
2008-07-11 19:33 ` [U-Boot-Users] [PATCH 3/7] sbc8560: define eth0 and eth1 instead of eth1 and eth2 Paul Gortmaker
2008-07-11 19:33 ` [U-Boot-Users] [PATCH 4/7] sbc8560: add in ft_board_setup() Paul Gortmaker
2008-07-11 19:33 ` [U-Boot-Users] [PATCH 5/7] sbc8560: add default fdt values Paul Gortmaker
2008-07-11 19:33 ` [U-Boot-Users] [PATCH 6/7] sbc8560: enable CONFIG_OF_LIBFDT by default Paul Gortmaker
2008-07-15 1:09 ` Andy Fleming
2008-07-11 20:30 ` [U-Boot-Users] [PATCH 5/7] sbc8560: add default fdt values Wolfgang Denk
2008-07-11 22:02 ` Paul Gortmaker
2008-07-15 1:06 ` Andy Fleming
2008-07-15 1:07 ` [U-Boot-Users] [PATCH 4/7] sbc8560: add in ft_board_setup() Andy Fleming
2008-07-11 19:41 ` [U-Boot-Users] [PATCH 3/7] sbc8560: define eth0 and eth1 instead of eth1 and eth2 Ben Warren
2008-07-11 20:24 ` Wolfgang Denk
2008-07-11 22:03 ` Paul Gortmaker [this message]
2008-07-15 0:51 ` Andy Fleming
2008-07-15 6:25 ` Wolfgang Denk
2008-07-15 13:14 ` Ben Warren
2008-07-15 13:28 ` Paul Gortmaker
2008-07-15 1:07 ` [U-Boot-Users] [PATCH 2/7] sbc8560: properly set cs0_bnds for 512MB Andy Fleming
2008-07-15 0:34 ` [U-Boot-Users] [PATCH 1/7] sbc8560: proper definitions for TSEC Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4877D8C8.7010300@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox