public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] mpc85xx: make the MxMR register in upmconfig as a parameter
Date: Tue, 15 Jul 2008 13:00:12 +0200	[thread overview]
Message-ID: <487C833C.3090603@grandegger.com> (raw)
In-Reply-To: <20080714105432.GA18158@www.tglx.de>

Sebastian Siewior wrote:
> The default value for the MxMR register is not always the right one.
> This patch adds the value of MxMR register as an additional
> parameter (plus a few defines instead of hex coded values).
> 
> Signed-off-by: Sebastian Siewior <bigeasy@linutronix.de>
> ---
>  cpu/mpc85xx/cpu.c |   17 +++++++++++------
>  include/common.h  |    4 ++++
>  2 files changed, 15 insertions(+), 6 deletions(-)
> 
> diff --git a/cpu/mpc85xx/cpu.c b/cpu/mpc85xx/cpu.c
> index 2373b4a..081e804 100644
> --- a/cpu/mpc85xx/cpu.c
> +++ b/cpu/mpc85xx/cpu.c
> @@ -314,16 +314,21 @@ int dma_xfer(void *dest, uint count, void *src) {
>  	return dma_check();
>  }
>  #endif
> +
> +#define MXMR_OP_NORMAL	(0x00000000)
> +#define MXMR_OP_WRITE	(0x10000000)
> +#define MXMR_OP_READ	(0x20000000)
> +#define MXMR_OP_RUN	(0x30000000)

Please use the the corresponding definitions from 
"include/asm-ppc/fsl_lbc.h".

  parent reply	other threads:[~2008-07-15 11:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-14 10:54 [U-Boot-Users] [PATCH] mpc85xx: make the MxMR register in upmconfig as a parameter Sebastian Siewior
2008-07-15  0:27 ` Andy Fleming
2008-07-15  9:13   ` Sebastian Siewior
2008-07-15 11:28     ` Wolfgang Grandegger
2008-07-20 11:51       ` Sebastian Siewior
2008-07-21 10:13         ` Wolfgang Grandegger
2008-07-15 11:00 ` Wolfgang Grandegger [this message]
2008-07-15 11:28   ` Sebastian Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487C833C.3090603@grandegger.com \
    --to=wg@grandegger.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox