[U-Boot-Users] v1.3.4-rc1 released

[U-Boot-Users] v1.3.4-rc1 released

[Wolfgang Denk]

Hello,

the first release candidate for v1.3.4 is out.  Well,  actually  it's
more some mile stone than a real release candidate as we still have a
couple  of  issues  that  need  to  be fixed before we can consider a
release:

PPC:

- MPC8272ADS:
	pci.c: In function 'ft_pci_setup':
	pci.c:460: error: 'bd_t' has no member named 'pci_clk'
  => will be fixed as suggested on ML

- MVBC_P:
	e1000.c: In function 'e1000_read_mac_addr':
	e1000.c:518: warning: integer constant is too large for 'long' type
	mvbc_p.c: In function 'mvbc_init_gpio':
	mvbc_p.c:112: warning: format '%08x' expects type 'unsigned int', but argument 2 has type 'long unsign
	ed int'
	mvbc_p.c:123: warning: dereferencing type-punned pointer will break strict-aliasing rules
	mvbc_p.c: In function 'mvbc_p_load_fpga':
	mvbc_p.c:247: warning: implicit declaration of function 'fpga_load'

- W7OLMG:
	post2.c: In function 'dtt_test':
	post2.c:81: error: 'DTT_READ_TEMP' undeclared (first use in this function)
	post2.c:81: error: (Each undeclared identifier is reported only once
	post2.c:81: error: for each function it appears in.)
	post2.c:82: error: 'DTT_TEMP_SET' undeclared (first use in this function)
	post2.c:83: error: 'DTT_TEMP_HYST' undeclared (first use in this function)
	make[1]: *** [/work/wd/tmp-ppc/board/w7o/post2.o] Error 1
	make[1]: *** Waiting for unfinished jobs....
	make: *** [/work/wd/tmp-ppc/board/w7o/libw7o.a] Error 2

- haleakala_nand:
	make[1]: *** No rule to make target `/work/wd/tmp-ppc/nand_spl/board/amcc/kilauea/.depend', needed by `all'.  Stop.

	[Out-of-tree building fails, in-tree it works.]

- kilauea_nand:
	make[1]: *** No rule to make target `/work/wd/tmp-ppc/nand_spl/board/amcc/kilauea/.depend', needed by `all'.  Stop.

	[Out-of-tree building fails, in-tree it works.]

- sacsng:
	main.c: In function 'abortboot':
	main.c:119: warning: too many arguments for format

	Here we need some clever idea to deal with configurable command prompts.
	I will look into this asap.

- sc3:
	main.c: In function 'abortboot':
	main.c:119: warning: too many arguments for format

- actux4:
	actux4.c:83: warning: left shift count >= width of type
	actux4.c:83: warning: left shift count >= width of type

- adsvix:
	cmd_ide.c: In function '__ide_outb':
	cmd_ide.c:825: warning: implicit declaration of function 'outb'
	cmd_ide.c: In function '__ide_inb':
	cmd_ide.c:834: warning: implicit declaration of function 'inb'
	pcmcia.c:39:2: warning: #warning "Board will only supply 5V, wait for next HW spin for selectable power"
	common/libcommon.a(cmd_ide.o): In function `__ide_outb':
	/home/wd/git/u-boot/work/common/cmd_ide.c:825: undefined reference to `outb'
	common/libcommon.a(cmd_ide.o): In function `__ide_inb':
	/home/wd/git/u-boot/work/common/cmd_ide.c:834: undefined reference to `inb'

- apollon:
	make: *** /work/wd/tmp-arm/onenand_ipl/board/apollon: No such file or directory.  Stop.

- at91rm9200dk:
	In file included from /home/wd/git/u-boot/work/include/nand.h:32,
			 from board.c:48:
	/home/wd/git/u-boot/work/include/linux/mtd/nand.h:82:1: warning: "NAND_CTL_SETCLE" redefined
	In file included from /work/wd/tmp-arm/include/config.h:2,
			 from /home/wd/git/u-boot/work/include/common.h:35,
			 from board.c:41:
	/home/wd/git/u-boot/work/include/configs/at91rm9200dk.h:153:1: warning: this is the location of the previous definition
	In file included from /home/wd/git/u-boot/work/include/nand.h:32,
			 from board.c:48:
	/home/wd/git/u-boot/work/include/linux/mtd/nand.h:84:1: warning: "NAND_CTL_CLRCLE" redefined
	In file included from /work/wd/tmp-arm/include/config.h:2,
			 from /home/wd/git/u-boot/work/include/common.h:35,
			 from board.c:41:
	/home/wd/git/u-boot/work/include/configs/at91rm9200dk.h:152:1: warning: this is the location of the previous definition
	In file included from /home/wd/git/u-boot/work/include/nand.h:32,
			 from board.c:48:
	/home/wd/git/u-boot/work/include/linux/mtd/nand.h:86:1: warning: "NAND_CTL_SETALE" redefined
	In file included from /work/wd/tmp-arm/include/config.h:2,
			 from /home/wd/git/u-boot/work/include/common.h:35,
			 from board.c:41:
	/home/wd/git/u-boot/work/include/configs/at91rm9200dk.h:151:1: warning: this is the location of the previous definition
	In file included from /home/wd/git/u-boot/work/include/nand.h:32,
			 from board.c:48:
	/home/wd/git/u-boot/work/include/linux/mtd/nand.h:88:1: warning: "NAND_CTL_CLRALE" redefined
	In file included from /work/wd/tmp-arm/include/config.h:2,
			 from /home/wd/git/u-boot/work/include/common.h:35,
			 from board.c:41:
	/home/wd/git/u-boot/work/include/configs/at91rm9200dk.h:150:1: warning: this is the location of the previous definition

- csb637:
	In file included from /home/wd/git/u-boot/work/include/nand.h:32,
			 from board.c:48:
	/home/wd/git/u-boot/work/include/linux/mtd/nand.h:82:1: warning: "NAND_CTL_SETCLE" redefined
	In file included from /work/wd/tmp-arm/include/config.h:2,
			 from /home/wd/git/u-boot/work/include/common.h:35,
			 from board.c:41:
	/home/wd/git/u-boot/work/include/configs/csb637.h:156:1: warning: this is the location of the previous definition
	In file included from /home/wd/git/u-boot/work/include/nand.h:32,
			 from board.c:48:
	/home/wd/git/u-boot/work/include/linux/mtd/nand.h:84:1: warning: "NAND_CTL_CLRCLE" redefined
	In file included from /work/wd/tmp-arm/include/config.h:2,
			 from /home/wd/git/u-boot/work/include/common.h:35,
			 from board.c:41:
	/home/wd/git/u-boot/work/include/configs/csb637.h:155:1: warning: this is the location of the previous definition
	In file included from /home/wd/git/u-boot/work/include/nand.h:32,
			 from board.c:48:
	/home/wd/git/u-boot/work/include/linux/mtd/nand.h:86:1: warning: "NAND_CTL_SETALE" redefined
	In file included from /work/wd/tmp-arm/include/config.h:2,
			 from /home/wd/git/u-boot/work/include/common.h:35,
			 from board.c:41:
	/home/wd/git/u-boot/work/include/configs/csb637.h:154:1: warning: this is the location of the previous definition
	In file included from /home/wd/git/u-boot/work/include/nand.h:32,
			 from board.c:48:
	/home/wd/git/u-boot/work/include/linux/mtd/nand.h:88:1: warning: "NAND_CTL_CLRALE" redefined
	In file included from /work/wd/tmp-arm/include/config.h:2,
			 from /home/wd/git/u-boot/work/include/common.h:35,
			 from board.c:41:
	/home/wd/git/u-boot/work/include/configs/csb637.h:153:1: warning: this is the location of the previous definition

- ixp boards broken because of NPE Microcode issue

- m501sk, voiceblue:
	main.c: In function 'abortboot':
	main.c:215: warning: too many arguments for format

	See above.


Please help testing and cleaning up the bugs.

Thanks.

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To be is to program.

[U-Boot-Users] v1.3.4-rc1 released

[Jerry Van Baren]

Wolfgang Denk wrote:
> Hello,
> 
> the first release candidate for v1.3.4 is out.

:-)

> Well,  actually  it's more some mile stone than a real release
> candidate as we still have a couple  of  issues  that  need  to  be
> fixed before we can consider a release:

:-(

> - sacsng:
> 	main.c: In function 'abortboot':
> 	main.c:119: warning: too many arguments for format
> 
> 	Here we need some clever idea to deal with configurable command prompts.
> 	I will look into this asap.

I'll look at this tonight.  Maybe the code is being more clever than it 
should be or maybe I was simply stupider than I should have been.

Best regards,
gvb

[U-Boot-Users] v1.3.4-rc1 released

[Scott Wood]

On Wed, Jul 16, 2008 at 01:18:31PM +0200, Wolfgang Denk wrote:
> - at91rm9200dk:
> 	In file included from /home/wd/git/u-boot/work/include/nand.h:32,
> 			 from board.c:48:
> 	/home/wd/git/u-boot/work/include/linux/mtd/nand.h:82:1: warning: "NAND_CTL_SETCLE" redefined
> 	In file included from /work/wd/tmp-arm/include/config.h:2,
> 			 from /home/wd/git/u-boot/work/include/common.h:35,
> 			 from board.c:41:
> 	/home/wd/git/u-boot/work/include/configs/at91rm9200dk.h:153:1: warning: this is the location of the previous definition
> 	In file included from /home/wd/git/u-boot/work/include/nand.h:32,
> 			 from board.c:48:
> 	/home/wd/git/u-boot/work/include/linux/mtd/nand.h:84:1: warning: "NAND_CTL_CLRCLE" redefined
> 	In file included from /work/wd/tmp-arm/include/config.h:2,
> 			 from /home/wd/git/u-boot/work/include/common.h:35,
> 			 from board.c:41:
> 	/home/wd/git/u-boot/work/include/configs/at91rm9200dk.h:152:1: warning: this is the location of the previous definition

This board seems to be using the legacy NAND interface, but doesn't
define CFG_NAND_LEGACY.  It also doesn't define CONFIG_CMD_NAND; if one
does so, then it gets build errors (with or without CFG_NAND_LEGACY).

> - csb637:

Likewise.

-Scott

[U-Boot-Users] v1.3.4-rc1 released

[Wolfgang Denk]

In message <20080723191215.GA6559@ld0162-tx32.am.freescale.net> you wrote:
>
> > - at91rm9200dk:
> > 	In file included from /home/wd/git/u-boot/work/include/nand.h:32,
> > 			 from board.c:48:
> > 	/home/wd/git/u-boot/work/include/linux/mtd/nand.h:82:1: warning: "NAND_CTL_SETCLE" redefined
> > 	In file included from /work/wd/tmp-arm/include/config.h:2,
> > 			 from /home/wd/git/u-boot/work/include/common.h:35,
> > 			 from board.c:41:
> > 	/home/wd/git/u-boot/work/include/configs/at91rm9200dk.h:153:1: warning: this is the location of the previous definition
> > 	In file included from /home/wd/git/u-boot/work/include/nand.h:32,
> > 			 from board.c:48:
> > 	/home/wd/git/u-boot/work/include/linux/mtd/nand.h:84:1: warning: "NAND_CTL_CLRCLE" redefined
> > 	In file included from /work/wd/tmp-arm/include/config.h:2,
> > 			 from /home/wd/git/u-boot/work/include/common.h:35,
> > 			 from board.c:41:
> > 	/home/wd/git/u-boot/work/include/configs/at91rm9200dk.h:152:1: warning: this is the location of the previous definition
> 
> This board seems to be using the legacy NAND interface, but doesn't
> define CFG_NAND_LEGACY.  It also doesn't define CONFIG_CMD_NAND; if one
> does so, then it gets build errors (with or without CFG_NAND_LEGACY).
> 
> > - csb637:
> 
> Likewise.

So is there an easy way to fix these boards?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You don't need a weatherman to know which way the wind blows.
                                                          - Bob Dylan

[U-Boot-Users] v1.3.4-rc1 released

[Scott Wood]

On Tue, Jul 29, 2008 at 04:37:35PM +0200, Wolfgang Denk wrote:
> In message <20080723191215.GA6559@ld0162-tx32.am.freescale.net> you wrote:
> > This board seems to be using the legacy NAND interface, but doesn't
> > define CFG_NAND_LEGACY.  It also doesn't define CONFIG_CMD_NAND; if one
> > does so, then it gets build errors (with or without CFG_NAND_LEGACY).
> > 
> > > - csb637:
> > 
> > Likewise.
> 
> So is there an easy way to fix these boards?

Enable CFG_NAND_LEGACY and CONFIG_CMD_NAND, include whatever header that
the NAND macros depend on, fix any other build breaks, and test the
result.  I don't have the hardware to do that last step, so I'll leave it
up to the board maintainer.

-Scott

[U-Boot-Users] v1.3.4-rc1 released

[Wolfgang Denk]

In message <20080729164808.GE5215@ld0162-tx32.am.freescale.net> you wrote:
>
> > So is there an easy way to fix these boards?
> 
> Enable CFG_NAND_LEGACY and CONFIG_CMD_NAND, include whatever header that
> the NAND macros depend on, fix any other build breaks, and test the
> result.  I don't have the hardware to do that last step, so I'll leave it
> up to the board maintainer.

OK, thanks - I think I fixed it for at91rm9200dk, and disabled NAND
support for csb637.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The POP3 server service depends on the SMTP  server  service,  which
failed to start because of the following error: The operation comple-
ted successfully."                         -- Windows NT Server v3.51

[U-Boot-Users] v1.3.4-rc1 released

[Heiko Schocher]

Hello Wolfgang,

u-boot-users-request at lists.sourceforge.net wrote:
[...]

> - sc3:
> 	main.c: In function 'abortboot':
> 	main.c:119: warning: too many arguments for format

[PATCH] sc3: Fix compilerwarning:
          main.c:119: warning: too many arguments for format

Signed-off-by: Heiko Schocher <hs@denx.de>
---
 include/configs/sc3.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/include/configs/sc3.h b/include/configs/sc3.h
index f6e40de..0ff889a 100644
--- a/include/configs/sc3.h
+++ b/include/configs/sc3.h
@@ -132,7 +132,8 @@
 
 #if 1	/* feel free to disable for development */
 #define CONFIG_AUTOBOOT_KEYED		/* Enable password protection	*/
-#define CONFIG_AUTOBOOT_PROMPT		"\nSC3 - booting... stop with ENTER\n"
+#define CONFIG_AUTOBOOT_PROMPT		"\nSC3 - booting in %d seconds ..." \
+					" stop with ENTER\n"
 #define CONFIG_AUTOBOOT_DELAY_STR	"\r"	/* 1st "password"	*/
 #define CONFIG_AUTOBOOT_DELAY_STR2	"\n"	/* 1st "password"	*/
 #endif
-- 
1.5.6.1

[U-Boot-Users] v1.3.4-rc1 released

[Wolfgang Denk]

Dear Heiko,

in message <487E4C16.5050603@invitel.hu> you wrote:
> 
> diff --git a/include/configs/sc3.h b/include/configs/sc3.h
> index f6e40de..0ff889a 100644
> --- a/include/configs/sc3.h
> +++ b/include/configs/sc3.h
> @@ -132,7 +132,8 @@
>  
>  #if 1	/* feel free to disable for development */
>  #define CONFIG_AUTOBOOT_KEYED		/* Enable password protection	*/
> -#define CONFIG_AUTOBOOT_PROMPT		"\nSC3 - booting... stop with ENTER\n"
> +#define CONFIG_AUTOBOOT_PROMPT		"\nSC3 - booting in %d seconds ..." \
> +					" stop with ENTER\n"
>  #define CONFIG_AUTOBOOT_DELAY_STR	"\r"	/* 1st "password"	*/
>  #define CONFIG_AUTOBOOT_DELAY_STR2	"\n"	/* 1st "password"	*/
>  #endif

Thanks, but sorry - the customer was very specific about the message
to be printed. It cannot be changed :-(

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Wherever you go...There you are.                    - Buckaroo Banzai

[U-Boot-Users] v1.3.4-rc1 released

[Heiko Schocher]

Hello Wolfgang,

Wolfgang Denk wrote:
> Dear Heiko,
>
> in message <487E4C16.5050603@invitel.hu> you wrote:
>> diff --git a/include/configs/sc3.h b/include/configs/sc3.h
>> index f6e40de..0ff889a 100644
>> --- a/include/configs/sc3.h
>> +++ b/include/configs/sc3.h
>> @@ -132,7 +132,8 @@
>>
>>  #if 1	/* feel free to disable for development */
>>  #define CONFIG_AUTOBOOT_KEYED		/* Enable password protection	*/
>> -#define CONFIG_AUTOBOOT_PROMPT		"\nSC3 - booting... stop with ENTER\n"
>> +#define CONFIG_AUTOBOOT_PROMPT		"\nSC3 - booting in %d seconds ..." \
>> +					" stop with ENTER\n"
>>  #define CONFIG_AUTOBOOT_DELAY_STR	"\r"	/* 1st "password"	*/
>>  #define CONFIG_AUTOBOOT_DELAY_STR2	"\n"	/* 1st "password"	*/
>>  #endif

Didnt know this ... so we must change something in common/main.c :-(

Whats with something like this?

diff --git a/common/main.c b/common/main.c
index 79ad291..a8d05f4 100644
--- a/common/main.c
+++ b/common/main.c
@@ -87,6 +87,13 @@ int do_mdm_init = 0;
 extern void mdm_init(void); /* defined in board.c */
 #endif

+void __autoboot_prompt(int bootdelay)
+{
+	return;
+}
+void inline autoboot_prompt(int bootdelay)
+                __attribute__((weak, alias("__autoboot_prompt")));
+
 /***************************************************************************
  * Watch for 'delay' seconds for autoboot stop or autoboot delay string.
  * returns: 0 -  no key string, allow autoboot
@@ -115,9 +122,7 @@ static __inline__ int abortboot(int bootdelay)
 	u_int presskey_max = 0;
 	u_int i;

-#  ifdef CONFIG_AUTOBOOT_PROMPT
-	printf(CONFIG_AUTOBOOT_PROMPT, bootdelay);
-#  endif
+	autoboot_prompt(bootdelay);

 #  ifdef CONFIG_AUTOBOOT_DELAY_STR
 	if (delaykey[0].str == NULL)


and of course, we must also fix all boards which use CONFIG_AUTOBOOT_PROMPT :-(

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[U-Boot-Users] v1.3.4-rc1 released

[Wolfgang Denk]

In message <487EE97F.8010603@denx.de> you wrote:
> 
> Didnt know this ... so we must change something in common/main.c :-(

Yes.

> Whats with something like this?

Looks way too complicated to me. What do you think about the PATCH /
RFC I posted yesterday?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The light at the end of the tunnel is usually a "No Exit" sign.

[U-Boot-Users] v1.3.4-rc1 released

[Heiko Schocher]

Hello Wolfgang,

Wolfgang Denk wrote:
> In message <487EE97F.8010603@denx.de> you wrote:
>> Whats with something like this?
> 
> Looks way too complicated to me. What do you think about the PATCH /
> RFC I posted yesterday?

Why complicated? I think (means that I must verify it) the compiler
shouldnt generate code when using the default function. And every board
writer have a nice function, where he can print whatever he wants,
and my feeling is better when using a function than a define with a
argument list ...

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[U-Boot-Users] v1.3.4-rc1 released

[Jerry Van Baren]

Wolfgang Denk wrote:
> In message <487EE97F.8010603@denx.de> you wrote:
>> Didnt know this ... so we must change something in common/main.c :-(
> 
> Yes.
> 
>> Whats with something like this?
> 
> Looks way too complicated to me. What do you think about the PATCH /
> RFC I posted yesterday?
> 
> Best regards,
> 
> Wolfgang Denk

I presume you considered and discarded using a special #define (e.g. 
CONFIG_AUTOBOOT_PROMPT_0) for the no value case.  It only hurts our 
#ifdef hellcount a little and changes our "touch" count from <all> to 5 
(4 if I fix sacsng).

diff --git a/common/main.c b/common/main.c
index 79ad291..09e6033 100644
--- a/common/main.c
+++ b/common/main.c
@@ -115,8 +115,10 @@ static __inline__ int abortboot(int bootdelay)
         u_int presskey_max = 0;
         u_int i;

-#  ifdef CONFIG_AUTOBOOT_PROMPT
+#  if defined(CONFIG_AUTOBOOT_PROMPT)
         printf(CONFIG_AUTOBOOT_PROMPT, bootdelay);
+#  elif defined(CONFIG_AUTOBOOT_PROMPT_0)
+       c
  #  endif

  #  ifdef CONFIG_AUTOBOOT_DELAY_STR

[U-Boot-Users] v1.3.4-rc1 released

[Jerry Van Baren]

Jerry Van Baren wrote:
> Wolfgang Denk wrote:
>> In message <487EE97F.8010603@denx.de> you wrote:
>>> Didnt know this ... so we must change something in common/main.c :-(
>> Yes.
>>
>>> Whats with something like this?
>> Looks way too complicated to me. What do you think about the PATCH /
>> RFC I posted yesterday?
>>
>> Best regards,
>>
>> Wolfgang Denk
> 
> I presume you considered and discarded using a special #define (e.g. 
> CONFIG_AUTOBOOT_PROMPT_0) for the no value case.  It only hurts our 
> #ifdef hellcount a little and changes our "touch" count from <all> to 5 
> (4 if I fix sacsng).
> 
> diff --git a/common/main.c b/common/main.c
> index 79ad291..09e6033 100644
> --- a/common/main.c
> +++ b/common/main.c
> @@ -115,8 +115,10 @@ static __inline__ int abortboot(int bootdelay)
>          u_int presskey_max = 0;
>          u_int i;
> 
> -#  ifdef CONFIG_AUTOBOOT_PROMPT
> +#  if defined(CONFIG_AUTOBOOT_PROMPT)
>          printf(CONFIG_AUTOBOOT_PROMPT, bootdelay);
> +#  elif defined(CONFIG_AUTOBOOT_PROMPT_0)
> +       c

Arrr, missed the <ctl> key and other sorts of evil
+       printf(CONFIG_AUTOBOOT_PROMPT_0);

>   #  endif
> 
>   #  ifdef CONFIG_AUTOBOOT_DELAY_STR

[U-Boot-Users] v1.3.4-rc1 released

[Heiko Schocher]

Hello Jerry,

Jerry Van Baren wrote:
> Jerry Van Baren wrote:
>> Wolfgang Denk wrote:
>>> In message <487EE97F.8010603@denx.de> you wrote:
>>>> Didnt know this ... so we must change something in common/main.c :-(
>>> Yes.
>>>
>>>> Whats with something like this?
>>> Looks way too complicated to me. What do you think about the PATCH /
>>> RFC I posted yesterday?
>>>
>>> Best regards,
>>>
>>> Wolfgang Denk
>>
>> I presume you considered and discarded using a special #define (e.g.
>> CONFIG_AUTOBOOT_PROMPT_0) for the no value case.  It only hurts our
>> #ifdef hellcount a little and changes our "touch" count from <all> to
>> 5 (4 if I fix sacsng).
>>
>> diff --git a/common/main.c b/common/main.c
>> index 79ad291..09e6033 100644
>> --- a/common/main.c
>> +++ b/common/main.c
>> @@ -115,8 +115,10 @@ static __inline__ int abortboot(int bootdelay)
>>          u_int presskey_max = 0;
>>          u_int i;
>>
>> -#  ifdef CONFIG_AUTOBOOT_PROMPT
>> +#  if defined(CONFIG_AUTOBOOT_PROMPT)
>>          printf(CONFIG_AUTOBOOT_PROMPT, bootdelay);
>> +#  elif defined(CONFIG_AUTOBOOT_PROMPT_0)
>> +       c
> 
> Arrr, missed the <ctl> key and other sorts of evil
> +       printf(CONFIG_AUTOBOOT_PROMPT_0);
> 

Hmm.. and if somebody wants to print more variables we make more defines,
maybe for every board +1 define? I vote for making this in a weak function,
and each board code can print what he wants ...

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany