From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Hawkins <dwh@ovro.caltech.edu>
Date: Mon, 21 Jul 2008 10:46:19 -0700
Subject: [U-Boot-Users] RFQ: disable flash writes until after relocation?
In-Reply-To: <4884AFE1.3080001@freescale.com>
References: <20080720200750.F16F8248BF@gemini.denx.de>
	<4884AFE1.3080001@freescale.com>
Message-ID: <4884CB6B.6040708@ovro.caltech.edu>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Timur,

> I'm working on a patch that blocks i2c_init() from writing to
> global variables before relocation has occurred.  But if
> you're saying that this patch should not be necessary,
> then that would be better.

The I2C patch is necessary.

Whatever was written to i2c_bus_speed[0] was never actually
written, since the write occurs to flash before relocation,
so whatever the intent of the write was, needs to be fixed.

Wolfgang did not like the idea of adding code to disable
writes to flash at the processor-level before relocation.
This has the unfortunate side-effect of masking errors
such as the one your code added.

Please don't feel bad about this discussion, bugs happen :)

Cheers,
Dave