From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] fsl-i2c: fix writes to data segment before relocation
Date: Mon, 21 Jul 2008 15:31:29 -0500 [thread overview]
Message-ID: <4884F221.3070808@freescale.com> (raw)
In-Reply-To: <4884F1A0.8000707@ovro.caltech.edu>
David Hawkins wrote:
> Hi Timur,
>
>> - i2c_bus_speed[0] = set_i2c_bus_speed(dev, gd->i2c1_clk, speed);
>> + temp = set_i2c_bus_speed(dev, gd->i2c1_clk, speed);
>> + if (gd->flags & GD_FLG_RELOC)
>> + i2c_bus_speed[0] = temp;
>
> Does i2c_init() get called again after relocation?
Yes.
> I guess in some cases a board with fixed DDR would not
> need to initialize the I2C controller until after
> relocation.
We're okay then, too.
> If you need I2C speed tracking code, why not just re-read
> the I2C controller registers, and determine the speed from
> there? That is independent of relocation.
I suppose we could do that. I was planning on rewriting the I2C subsystem one
day, anyway.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2008-07-21 20:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 19:26 [U-Boot-Users] [PATCH] fsl-i2c: fix writes to data segment before relocation Timur Tabi
2008-07-21 20:13 ` Jean-Christophe PLAGNIOL-VILLARD
2008-07-21 20:21 ` Timur Tabi
2008-07-21 20:44 ` Wolfgang Denk
2008-07-21 20:29 ` David Hawkins
2008-07-21 20:31 ` Timur Tabi [this message]
2008-07-21 20:39 ` Jerry Van Baren
2008-07-21 20:45 ` Wolfgang Denk
2008-07-29 22:10 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4884F221.3070808@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox