From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Date: Tue, 22 Jul 2008 06:39:06 -0500 Subject: [U-Boot-Users] [Patch 3/3] U-Boot-V2:Board:OMAP Introduce Beagle In-Reply-To: <20080722074254.GB7169@pengutronix.de> References: <20080722074254.GB7169@pengutronix.de> Message-ID: <4885C6DA.7020707@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Sascha Hauer said the following on 07/22/2008 02:42 AM: > On Mon, Jul 21, 2008 at 07:19:06PM -0500, Khandenahally, Raghavendra wrote: > > This function is unnecessarely big. The two arguments of MUX_VAL could > go together in one 32bit value. This way you could do a loop around an > array of mux values. Of course a struct type could do the same thing, > but having them in one 32bit value allows you to define speaking names > for the pin configs making it easier for future board developers. See > include/asm-arm/arch-imx/imx27-regs.h for an example for what I mean. > This is just an idea, I won't reject the patch because of this. > > Yes, it is obvious that a loop will look simpler, except that the code context here is in board_init - where only the bare minimum sram stack is available and cinit is not done.. inline code is a requirement here. Regards, Nishanth Menon