From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] NAND boot: Update large page support for current API.
Date: Tue, 05 Aug 2008 12:01:46 -0500 [thread overview]
Message-ID: <4898877A.4040003@freescale.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0808051843240.14484@axis700.grange>
Guennadi Liakhovetski wrote:
>> /* Begin command latch cycle */
>> - this->cmd_ctrl(mtd, cmd, ctrl);
>> + this->cmd_ctrl(mtd, cmd, NAND_CTRL_CLE | NAND_CTRL_CHANGE);
>
> [snip]
>
> See? you do the same! You replace short lowercase variable with long
> uppercase macros:-)
:-)
Yes, but in this case it's not just a name change; the old "ctrl"
variable was stateful and thus less clear.
-Scott
next prev parent reply other threads:[~2008-08-05 17:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 16:19 [U-Boot-Users] [PATCH] NAND boot: Update large page support for current API Scott Wood
2008-08-05 16:55 ` Guennadi Liakhovetski
2008-08-05 17:01 ` Scott Wood [this message]
2008-08-06 13:33 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4898877A.4040003@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox