From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Tue, 05 Aug 2008 12:01:46 -0500
Subject: [U-Boot-Users] [PATCH] NAND boot: Update large page support for
	current API.
In-Reply-To: <Pine.LNX.4.64.0808051843240.14484@axis700.grange>
References: <20080805161914.GA14311@ld0162-tx32.am.freescale.net>
	<Pine.LNX.4.64.0808051843240.14484@axis700.grange>
Message-ID: <4898877A.4040003@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Guennadi Liakhovetski wrote:
>>  	/* Begin command latch cycle */
>> -	this->cmd_ctrl(mtd, cmd, ctrl);
>> +	this->cmd_ctrl(mtd, cmd, NAND_CTRL_CLE | NAND_CTRL_CHANGE);
> 
> [snip]
> 
> See? you do the same! You replace short lowercase variable with long 
> uppercase macros:-) 

:-)

Yes, but in this case it's not just a name change; the old "ctrl" 
variable was stateful and thus less clear.

-Scott