public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jens Gehrlein <sew_s@tqs.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] nand_spl/nand_boot.c: why can't we do anything on ECC error?
Date: Wed, 13 Aug 2008 19:03:25 +0200	[thread overview]
Message-ID: <48A313DD.8020801@tqs.de> (raw)

Hi,

in nand_spl/nand_boot.c in function nand_read_page() one can read the 
comment in the case of ECC errors:
"No chance to do something with the possible error message from 
correct_data(). We just hope that all possible errors are corrected by 
this routine."

Why can't we do anything? If an uncorrectable error has been recognized, 
we could at least execute an endless loop or issue a reset. Depending on 
the bit errors and their location in the U-Boot image, U-Boot may though 
boot and a runtime error could probably appear never or later or only 
under special circumtances. Because this is a risk (the image is 
corrupted), what do you think of inserting some blocking functionality?

Or did I missed something in interpreting this code?

Kind regards,
Jens

             reply	other threads:[~2008-08-13 17:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-13 17:03 Jens Gehrlein [this message]
2008-08-13 17:18 ` [U-Boot] nand_spl/nand_boot.c: why can't we do anything on ECC error? Scott Wood
2008-08-14  7:42   ` Jens Gehrlein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A313DD.8020801@tqs.de \
    --to=sew_s@tqs.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox