From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] fdt: rework fdt_fixup_ethernet() to use env instead of bd_t
Date: Mon, 18 Aug 2008 14:49:05 -0500 [thread overview]
Message-ID: <48A9D231.5030703@freescale.com> (raw)
In-Reply-To: <119C6E28-E979-4B97-87AD-9603CD5FFDAA@kernel.crashing.org>
Kumar Gala wrote:
> On Aug 18, 2008, at 2:30 PM, Wolfgang Denk wrote:
>
>> Dear Kumar Gala,
>>
>> In message <Pine.LNX.
>> 4.64.0808181422320.28491 at blarg.am.freescale.net> you wrote:
>>> Move to using the environment variables 'ethaddr', 'eth1addr', etc..
>>> instead of bd->bi_enetaddr, bi_enet1addr, etc.
>>>
>>> This makes the code a bit more flexible to the number of ethernet
>>> interfaces. Right now we assume a max of 10 interfaces.
>> Hm... where exactly is this artificial limit coming from? Do we really
>> need it?
>
> We need some upper limit to stop checking at.
It might be better (and more efficent) to iterate over the environment,
and check each name against the eth*addr pattern.
-Scott
next prev parent reply other threads:[~2008-08-18 19:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 19:23 [U-Boot] [PATCH v2] fdt: rework fdt_fixup_ethernet() to use env instead of bd_t Kumar Gala
2008-08-18 19:30 ` Wolfgang Denk
2008-08-18 19:40 ` Kumar Gala
2008-08-18 19:49 ` Scott Wood [this message]
2008-08-18 19:57 ` Kumar Gala
2008-08-18 20:55 ` Wolfgang Denk
2008-08-18 21:04 ` Kumar Gala
2008-08-18 20:54 ` Wolfgang Denk
2008-08-18 23:53 ` Jerry Van Baren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A9D231.5030703@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox