From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 18 Aug 2008 14:49:05 -0500 Subject: [U-Boot] [PATCH v2] fdt: rework fdt_fixup_ethernet() to use env instead of bd_t In-Reply-To: <119C6E28-E979-4B97-87AD-9603CD5FFDAA@kernel.crashing.org> References: <20080818193004.145DE24899@gemini.denx.de> <119C6E28-E979-4B97-87AD-9603CD5FFDAA@kernel.crashing.org> Message-ID: <48A9D231.5030703@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Kumar Gala wrote: > On Aug 18, 2008, at 2:30 PM, Wolfgang Denk wrote: > >> Dear Kumar Gala, >> >> In message > 4.64.0808181422320.28491 at blarg.am.freescale.net> you wrote: >>> Move to using the environment variables 'ethaddr', 'eth1addr', etc.. >>> instead of bd->bi_enetaddr, bi_enet1addr, etc. >>> >>> This makes the code a bit more flexible to the number of ethernet >>> interfaces. Right now we assume a max of 10 interfaces. >> Hm... where exactly is this artificial limit coming from? Do we really >> need it? > > We need some upper limit to stop checking at. It might be better (and more efficent) to iterate over the environment, and check each name against the eth*addr pattern. -Scott