From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix OneNAND read_oob/write_oob functions compatability
Date: Mon, 18 Aug 2008 18:27:31 -0500 [thread overview]
Message-ID: <48AA0563.9020802@freescale.com> (raw)
In-Reply-To: <9c9fda240808181607r226386fey794c2febfbfd421@mail.gmail.com>
Kyungmin Park wrote:
>>> diff --git a/common/cmd_onenand.c b/common/cmd_onenand.c
>>> index 5e2062b..8d87b78 100644
>>> --- a/common/cmd_onenand.c
>>> +++ b/common/cmd_onenand.c
>>> @@ -85,15 +85,25 @@ int do_onenand(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
>>> ulong addr = simple_strtoul(argv[2], NULL, 16);
>>> ulong ofs = simple_strtoul(argv[3], NULL, 16);
>>> size_t len = simple_strtoul(argv[4], NULL, 16);
>>> - size_t retlen = 0;
>>> int oob = strncmp(argv[1], "read.oob", 8) ? 0 : 1;
>>> + struct mtd_oob_ops ops;
>>> +
>>> + ops.mode = MTD_OOB_PLACE;
>> I think this should be MTD_OOB_RAW.
>
> What's the difference? In the code it can't support the MTD_OOB_RAW case.
Sorry, I was confusing PLACE with AUTO.
-Scott
prev parent reply other threads:[~2008-08-18 23:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-16 5:32 [U-Boot] [PATCH] Fix OneNAND read_oob/write_oob functions compatability Kyungmin Park
2008-08-18 22:08 ` Scott Wood
2008-08-18 23:07 ` Kyungmin Park
2008-08-18 23:27 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AA0563.9020802@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox