From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 18 Aug 2008 18:27:31 -0500 Subject: [U-Boot] [PATCH] Fix OneNAND read_oob/write_oob functions compatability In-Reply-To: <9c9fda240808181607r226386fey794c2febfbfd421@mail.gmail.com> References: <20080816053216.GA5081@july> <20080818220844.GA25926@ld0162-tx32.am.freescale.net> <9c9fda240808181607r226386fey794c2febfbfd421@mail.gmail.com> Message-ID: <48AA0563.9020802@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Kyungmin Park wrote: >>> diff --git a/common/cmd_onenand.c b/common/cmd_onenand.c >>> index 5e2062b..8d87b78 100644 >>> --- a/common/cmd_onenand.c >>> +++ b/common/cmd_onenand.c >>> @@ -85,15 +85,25 @@ int do_onenand(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) >>> ulong addr = simple_strtoul(argv[2], NULL, 16); >>> ulong ofs = simple_strtoul(argv[3], NULL, 16); >>> size_t len = simple_strtoul(argv[4], NULL, 16); >>> - size_t retlen = 0; >>> int oob = strncmp(argv[1], "read.oob", 8) ? 0 : 1; >>> + struct mtd_oob_ops ops; >>> + >>> + ops.mode = MTD_OOB_PLACE; >> I think this should be MTD_OOB_RAW. > > What's the difference? In the code it can't support the MTD_OOB_RAW case. Sorry, I was confusing PLACE with AUTO. -Scott