From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rafal Jaworowski Date: Wed, 20 Aug 2008 09:10:38 +0200 Subject: [U-Boot] Location of jump table in global_data structure In-Reply-To: <1219199711.10790.28.camel@ptyser-laptop> References: <1219156535.1273.269.camel@localhost.localdomain> <48AB74B3.5090505@gmail.com> <1219199711.10790.28.camel@ptyser-laptop> Message-ID: <48ABC36E.5000101@semihalf.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Peter Tyser wrote: *snip* >>> Do others view this issue as a problem that should be fixed? >> Yes. >> >>> If others feel that the jt pointer should be moved to the 2nd item in >>> global_data structure let me know and I can generate a patch. >> Add a comment and police it is my vote. > > That's definitely an improvement, but doesn't handle both > adding/removing fields from the global_data structure in a clean manner. > I'd still lean towards moving the jt pointer to one of the earlier > fields of the structs as well as adding a comment. Then at least the > jump table portion of the API would be stable, even if accessing the > "global_data fields" API wouldn't. Right now, neither API is stable:) > > If anyone has any other clever ideas on improving the API, I'd be happy > to investigate/implement. There already is a modern API for external applications in U-Boot since 1.3.2 (but not enabled by default). Please see 'api/README' and 'api_examples' in the U-Boot tree. So far it has been used successfully on PowerPC and ARM; there's no support for AVR arch yet, but providing the syscall entry point for it shouldn't be a big deal for someone with AVR knowledge. Let me know if you'd be willing to chew on it (I don't have AVR h/w but can help/support regarding the API itself). kind regards, Rafal