[U-Boot] [PATCH] Standardize bootp, tftpboot, rarpboot, dhcp, and nfs command descriptions

[U-Boot] [PATCH] Standardize bootp, tftpboot, rarpboot, dhcp, and nfs command descriptions

[Peter Tyser]

cmd_net.c command descriptions were updated to describe the optional
hostIPaddr argument.  The dhcp command help message was also updated
to more closely reflect the other commands in cmd_net.c

Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
---

 common/cmd_net.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/common/cmd_net.c b/common/cmd_net.c
index 79e910c..af691a4 100644
--- a/common/cmd_net.c
+++ b/common/cmd_net.c
@@ -39,8 +39,8 @@ int do_bootp (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 
 U_BOOT_CMD(
 	bootp,	3,	1,	do_bootp,
-	"bootp\t- boot image via network using BootP/TFTP protocol\n",
-	"[loadAddress] [bootfilename]\n"
+	"bootp\t- boot image via network using BOOTP/TFTP protocol\n",
+	"[loadAddress] [[hostIPaddr:]bootfilename]\n"
 );
 
 int do_tftpb (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
@@ -62,7 +62,7 @@ int do_rarpb (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 U_BOOT_CMD(
 	rarpboot,	3,	1,	do_rarpb,
 	"rarpboot- boot image via network using RARP/TFTP protocol\n",
-	"[loadAddress] [bootfilename]\n"
+	"[loadAddress] [[hostIPaddr:]bootfilename]\n"
 );
 
 #if defined(CONFIG_CMD_DHCP)
@@ -73,8 +73,8 @@ int do_dhcp (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 
 U_BOOT_CMD(
 	dhcp,	3,	1,	do_dhcp,
-	"dhcp\t- invoke DHCP client to obtain IP/boot params\n",
-	"\n"
+	"dhcp\t- boot image via network using DHCP/TFTP protocol\n",
+	"[loadAddress] [[hostIPaddr:]bootfilename]\n"
 );
 #endif
 
-- 
1.5.4.3

[U-Boot] [PATCH] Standardize bootp, tftpboot, rarpboot, dhcp, and nfs command descriptions

[Ben Warren]

Hi Peter,

Peter Tyser wrote:
> cmd_net.c command descriptions were updated to describe the optional
> hostIPaddr argument.  The dhcp command help message was also updated
> to more closely reflect the other commands in cmd_net.c
>
> Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> ---
>   
I'm too lazy to check if this is different from the patch that you sent 
previously (8/13 or so).  I imagine you want this one applied and the 
other discarded?

regards,
Ben

[U-Boot] [PATCH] Standardize bootp, tftpboot, rarpboot, dhcp, and nfs command descriptions

[Peter Tyser]

Hi Ben,

On Tue, 2008-08-26 at 09:31 -0700, Ben Warren wrote:
> Hi Peter,
> 
> Peter Tyser wrote:
> > cmd_net.c command descriptions were updated to describe the optional
> > hostIPaddr argument.  The dhcp command help message was also updated
> > to more closely reflect the other commands in cmd_net.c
> >
> > Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> > ---
> >   
> I'm too lazy to check if this is different from the patch that you sent 
> previously (8/13 or so).  I imagine you want this one applied and the 
> other discarded?

The content of this patch is identical to the previous patch sent on
8/13.  However, the email on 8/13's title included "[RFC]" and in it I
made the following comment:

"Not sure if "boot" is the proper word to use in the command definitions
since the downloaded images are only booted if "autostart=yes", and
the majority of board configs don't have autostart set to yes.
I'd vote for changing the descriptions to "load image via...".
If a new, more granular bootm command is in the works,
it seems like even less people will autoboot an image
directly before doing some additional bootm commands to prep
for booting an OS. Do others have an opinion?"

No one seemed to bite as far as changing the wording of the commands, so
I re-sent the same patch without the [RFC] and cleaned up the commit
message to make it a formal patch.  So you're right, this patch should
be applied and the previous one on 8/13 discarded.

Thanks,
Peter

[U-Boot] [PATCH] Standardize bootp, tftpboot, rarpboot, dhcp, and nfs command descriptions

[Ben Warren]

Peter Tyser wrote:
> Hi Ben,
>
> On Tue, 2008-08-26 at 09:31 -0700, Ben Warren wrote:
>   
>> Hi Peter,
>>
>> Peter Tyser wrote:
>>     
>>> cmd_net.c command descriptions were updated to describe the optional
>>> hostIPaddr argument.  The dhcp command help message was also updated
>>> to more closely reflect the other commands in cmd_net.c
>>>
>>> Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
>>> ---
>>>   
>>>       
>> I'm too lazy to check if this is different from the patch that you sent 
>> previously (8/13 or so).  I imagine you want this one applied and the 
>> other discarded?
>>     
>
> The content of this patch is identical to the previous patch sent on
> 8/13.  However, the email on 8/13's title included "[RFC]" and in it I
> made the following comment:
>
> "Not sure if "boot" is the proper word to use in the command definitions
> since the downloaded images are only booted if "autostart=yes", and
> the majority of board configs don't have autostart set to yes.
> I'd vote for changing the descriptions to "load image via...".
> If a new, more granular bootm command is in the works,
> it seems like even less people will autoboot an image
> directly before doing some additional bootm commands to prep
> for booting an OS. Do others have an opinion?"
>
> No one seemed to bite as far as changing the wording of the commands, so
> I re-sent the same patch without the [RFC] and cleaned up the commit
> message to make it a formal patch.  So you're right, this patch should
> be applied and the previous one on 8/13 discarded.
>   
Good deal.  I'm hoping to get a few hours tonight to catch up.

regards,
Ben

[U-Boot] [PATCH] Standardize bootp, tftpboot, rarpboot, dhcp, and nfs command descriptions

[Ben Warren]

Peter Tyser wrote:
> cmd_net.c command descriptions were updated to describe the optional
> hostIPaddr argument.  The dhcp command help message was also updated
> to more closely reflect the other commands in cmd_net.c
>
> Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> ---
>   
Applied to net repo.

Thanks for cleaning this up!
Ben