public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2] Don't tftp to unknown flash
Date: Tue, 02 Sep 2008 21:25:30 -0700	[thread overview]
Message-ID: <48BE11BA.4020803@gmail.com> (raw)
In-Reply-To: <48BD066B.5070805@scram.de>

Jochen Friedrich wrote:
> If a board has a variable number of flash banks, there are empty entries
> in flash_info[] and CFG_DIRECT_FLASH_TFTP is set, tftp boot fails with
> "Outside available Flash". This patch skips flash banks with unknown
> flash ids.
>
> Signed-off-by: Jochen Friedrich <jochen@scram.de>
> ---
>  net/tftp.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/net/tftp.c b/net/tftp.c
> index 84d83ca..9aeecb8 100644
> --- a/net/tftp.c
> +++ b/net/tftp.c
> @@ -111,6 +111,8 @@ store_block (unsigned block, uchar * src, unsigned len)
>
>  	for (i=0; i<CFG_MAX_FLASH_BANKS; i++) {
>  		/* start address in flash? */
> +		if (flash_info[i].flash_id == FLASH_UNKNOWN)
> +			continue;
>  		if (load_addr + offset >= flash_info[i].start[0]) {
>  			rc = 1;
>  			break;
>   
Added to net repo.

thanks,
Ben

      reply	other threads:[~2008-09-03  4:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-02  9:24 [U-Boot] [PATCHv2] Don't tftp to unknown flash Jochen Friedrich
2008-09-03  4:25 ` Ben Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BE11BA.4020803@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox