public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andreas Engel <andreas.engel@ericsson.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [UPDATE #2] Merged serial_pl010.c and	serial_pl011.c.
Date: Mon, 08 Sep 2008 11:29:05 +0200	[thread overview]
Message-ID: <48C4F061.1090609@ericsson.com> (raw)
In-Reply-To: <20080908085608.GA3956@game.jcrosoft.org>

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 10:17 Mon 08 Sep     , Andreas Engel wrote:
>> [...]
>>
>> -#ifdef CFG_PL010_SERIAL
>> +#if defined(CFG_PL010_SERIAL) || defined(CFG_PL011_SERIAL)
> Please move this to the Makefile

Shouldn't this better be a separate patch?

Regards,
  Andreas

  reply	other threads:[~2008-09-08  9:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-25  7:11 [U-Boot] [PATCH] [UPDATE] Merged serial_pl010.c and serial_pl011.c Andreas Engel
2008-09-06 20:34 ` Wolfgang Denk
2008-09-08  8:17   ` [U-Boot] [PATCH] [UPDATE #2] " Andreas Engel
2008-09-08  8:56     ` Jean-Christophe PLAGNIOL-VILLARD
2008-09-08  9:29       ` Andreas Engel [this message]
2008-09-08 10:49         ` Wolfgang Denk
2008-09-08 12:30       ` [U-Boot] [PATCH] [ARM] Moved conditional compile into Makefile Andreas Engel
2008-09-08 13:30         ` Jean-Christophe PLAGNIOL-VILLARD
2008-09-08 14:06           ` Wolfgang Denk
2008-09-08 14:44             ` Andreas Engel
2008-09-09 12:41     ` [U-Boot] [PATCH] [UPDATE #2] Merged serial_pl010.c and serial_pl011.c Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C4F061.1090609@ericsson.com \
    --to=andreas.engel@ericsson.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox