From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 04/11 v1] ARM: OMAP3: Add assembly startup and sys_info common files
Date: Sat, 20 Sep 2008 18:25:05 +0200 [thread overview]
Message-ID: <48D523E1.8060508@googlemail.com> (raw)
In-Reply-To: <20080918071553.03148248D3@gemini.denx.de>
Dear Wolfgang,
Wolfgang Denk wrote:
> Dear Dirk Behme,
Just Dirk ;)
> In message <48CFF803.3080105@googlemail.com> you wrote:
>
>>Yes, from strict technical point of view you are correct. Cortex A8 is
>>the 'CPU' and OMAP3 is the SoC.
>>
>>But what do we win adding an additional directory layer
>>cpu/arm_cortexa8/omap3? Let's assume we will see an additional
>>Cortex-A8 core xxx in the future. Then we would have
>>
>>a)
>>
>>cpu/omap3/
>>cpu/xxx/
>
>
> ... which probably means code duplication.
>
>
>>*or*
>>
>>b)
>>
>>cpu/arm_cortexa8/omap3
>>cpu/arm_cortexa8/xxx
>>
>>What's better?
>
>
> Instead, we might probably have just a "cpu/arm_cortexa8/" with common
> code for "omap3" and "xxx" ?
Hmm, sorry, I'm not sure I completely understood.
Do you want to say that you want a directory "cpu/arm_cortexa8/" where
the common files for Corex-A8 CPUs are located and then a directory
"cpu/arm_cortexa8/omap3" where the OMAP3 common stuff is stored?
If this is correct, from theory I completely agree. *But*: From
practical point of view regarding the patch we are talking about here,
we just don't know what Corex-A8 CPU common code might be. As I know
there is no "xxx" (with xxx != OMAP3) yet, so it's hard to know what
will be common. So we moved all OMAP3 common code for all three buards
we currently support to omap3 directory.
So for the time being, I propose to create /cpu/arm_cortexa8/omap3
with all files in this directory and no files in /cpu/arm_cortexa8
yet. This can change later, files from omap3/ can move to
/cpu/arm_cortexa8/ when we get more Cortex-A8 SoCs/chips and get an
idea what might be common.
>>If U-Boot maintainers want cpu/arm_cortexa8/xxx, I wonder if we could
>>do this using git to move the files once the patches are applied? It
>
> I think we shoud try and start without the xxx part.
Yes, as "xxx" doesn't exist yet ;)
But my question here was if we can do directory moves/renames in git
after/while patch is applied or if new patches with directory changes
are needed on mailing list? Directory move/rename is easy in git,
while doing this with patches to mailing list may result in
unnecessary traffic.
Thanks
Dirk
next prev parent reply other threads:[~2008-09-20 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-14 9:50 [U-Boot] [PATCH 04/11 v1] ARM: OMAP3: Add assembly startup and sys_info common files dirk.behme at googlemail.com
2008-09-15 6:52 ` Magnus Lilja
2008-09-16 18:16 ` Dirk Behme
2008-09-18 7:15 ` Wolfgang Denk
2008-09-20 16:25 ` Dirk Behme [this message]
2008-10-13 23:21 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D523E1.8060508@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox