public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: richardretanubun <richardretanubun@ruggedcom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] [83xx] Adds two more ethernet interface to 83xx
Date: Thu, 25 Sep 2008 18:52:39 -0400	[thread overview]
Message-ID: <48DC1637.5000707@ruggedcom.com> (raw)
In-Reply-To: <20080925222439.8858F24851@gemini.denx.de>

Wolfgang Denk wrote:

> Dear richardretanubun,
>
> In message <48DC0652.5030409@ruggedcom.com> you wrote:
>> +++ b/README
>> @@ -1097,6 +1097,9 @@ The following options need to be configured:
>>  		CONFIG_ETHADDR
>>  		CONFIG_ETH2ADDR
>>  		CONFIG_ETH3ADDR
>> +		CONFIG_ETH4ADDR
>> +		CONFIG_ETH5ADDR
>> +		CONFIG_ETH6ADDR
>
> Sorry, but I still don't get why CONFIG_ETH1ADDR isn't there?
>
> This will make the loop in fdt_fixup_ethernet() terminate unexpectedly
> early.
>
Sorry Wolfgang, the V2 is sent before I red Kim's !ack 
about the comments on CONFIG_ETH1ADDR being the implicit CONFIG_ETHADDR (which is not true)

Please disregard V2. V1 is correct, except for this change:

diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
>> index f4d9d40..67cc64f 100644
>> --- a/common/cmd_bdinfo.c
>> +++ b/common/cmd_bdinfo.c
>> @@ -91,11 +91,12 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
>>  	print_str ("pevfreq",	    strmhz(buf, bd->bi_pevfreq));
>>  #endif
>>  
>> +#if defined(CONFIG_HAS_ETH0)
>>  	puts ("ethaddr     =");
>>  	for (i=0; i<6; ++i) {
>>  		printf ("%c%02X", i ? ':' : ' ', bd->bi_enetaddr[i]);
>>  	}
>> -
>> +#endif
>
>[KP] how is the above change relevant to the patch subject?
[RR] Good catch, I lumped it together because I was in the code neighborhood 
     and got carried away in making the code uniform. I will pull it out of this patch.


- Richard

  reply	other threads:[~2008-09-25 22:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-25 12:53 [U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx richardretanubun
2008-09-25 19:50 ` Kim Phillips
2008-09-25 20:25   ` richardretanubun
2008-09-25 20:45     ` Kim Phillips
2008-09-25 22:08       ` Wolfgang Denk
2008-09-25 21:44     ` [U-Boot] [PATCH v2] " richardretanubun
2008-09-25 22:24       ` Wolfgang Denk
2008-09-25 22:52         ` richardretanubun [this message]
2008-09-25 23:28           ` Wolfgang Denk
2008-09-29 12:43             ` richardretanubun
2008-09-29 13:07               ` Jerry Van Baren
2008-09-29 22:28                 ` [U-Boot] [PATCH v3] " richardretanubun
2008-09-30 16:00                   ` Kim Phillips
2008-09-30 15:58                     ` Jerry Van Baren
2008-09-30 17:02                     ` Ben Warren
2008-10-06  5:12                   ` Ben Warren
2008-10-06 19:31                     ` richardretanubun
2008-10-14  5:53                       ` Ben Warren
2008-09-25 22:24   ` [U-Boot] [PATCH] " Wolfgang Denk
2008-09-25 20:42 ` Jerry Van Baren
2008-09-25 22:17   ` Wolfgang Denk
2008-09-26  3:44 ` Jerry Van Baren
2008-09-26  5:46   ` Wolfgang Denk
2008-09-26  7:21   ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48DC1637.5000707@ruggedcom.com \
    --to=richardretanubun@ruggedcom.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox