[U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx

Wolfgang Denk
2008-09-25T22:08:40Z

Dear Kim Phillips,

In message <20080925154546.4ff2cae2.kim.phillips@freescale.com> you wrote:
>
> > >> - Ethernet address:
> > >> CONFIG_ETHADDR
> > >> + CONFIG_ETH1ADDR
> > >> CONFIG_ETH2ADDR
> > >
> > > hmm..historically ETHADDR has been the implicit ETH1ADDR. Did you mean
> > > to s/ETHADDR/ETH1ADDR/ ? if so, you'd need a better justification and
> > > a much larger patch. Otherwise, please don't do this; add a
> > > CONFIG_ETH6ADDR below instead.

No, numbering starts at 0 and matches Linux interface names.

CONFIG_ETHADDR => "ethaddr" => "eth0"
CONFIG_ETH1ADDR => "eth1addr" => "eth1"
...
CONFIG_ETHNADDR => "ethNaddr" => "ethN"

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
For those who like this sort of thing, this is the sort of thing they
like. - Abraham Lincoln