From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Thu, 25 Sep 2008 23:40:46 -0700
Subject: [U-Boot] [PATCH 08/11 v1] ARM: OMAP3: Add I2C and network
	support
In-Reply-To: <48ccdf1d.1f205e0a.3c76.5e64@mx.google.com>
References: <48ccdf1d.1f205e0a.3c76.5e64@mx.google.com>
Message-ID: <48DC83EE.5060004@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

dirk.behme at googlemail.com wrote:
> Subject: [PATCH 08/11 v1] ARM: OMAP3: Add I2C and network support
>
> From: Dirk Behme <dirk.behme@gmail.com>
>
> Add I2C and network support
>
>   
I2C and network bits are kinda unrelated, don't you think?
<snip>
> Index: u-boot_master/net/eth.c
> ===================================================================
> --- u-boot_master.orig/net/eth.c
> +++ u-boot_master/net/eth.c
> @@ -508,7 +508,7 @@ extern int emac4xx_miiphy_initialize(bd_
>  extern int mcf52x2_miiphy_initialize(bd_t *bis);
>  extern int ns7520_miiphy_initialize(bd_t *bis);
>  extern int davinci_eth_miiphy_initialize(bd_t *bis);
> -
> +extern int eth_init(bd_t *bd);
>  
>  int eth_initialize(bd_t *bis)
>  {
> @@ -532,6 +532,9 @@ int eth_initialize(bd_t *bis)
>  #if defined(CONFIG_DRIVER_TI_EMAC)
>  	davinci_eth_miiphy_initialize(bis);
>  #endif
> +#if defined(CONFIG_DRIVER_SMC911X)
> +	eth_init(bis);
>   
This isn't the right place to call eth_init(). I know the namespaces are 
pretty convoluted, but the eth_initialize() family of functions are 
intended to do things like register devices, initialize data structures 
etc. without actually enabling the device. eth_init() enables a device. 
The SMC911X driver doesn' t have such a thing, which is why none of the 
other boards that use this chip have anything in this file.
> +#endif
>  	return 0;
>  }
>  #endif
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>